From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7F906958A for ; Wed, 21 Oct 2015 14:06:00 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 21 Oct 2015 05:04:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,711,1437462000"; d="scan'208";a="832078753" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga002.fm.intel.com with ESMTP; 21 Oct 2015 05:04:31 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Oct 2015 13:04:31 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by irsmsx155.ger.corp.intel.com ([169.254.14.242]) with mapi id 14.03.0248.002; Wed, 21 Oct 2015 13:04:30 +0100 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , Yoni Fogel Thread-Topic: [dpdk-dev] [PATCH] lib: rte_*_create gives NULL/EEXIST on duped name Thread-Index: AQHRC3hJiqRtDd/VfUS/oO72kFb6NJ51t0qAgAAizZA= Date: Wed, 21 Oct 2015 12:04:30 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836AB33D9@irsmsx105.ger.corp.intel.com> References: <1445372497-817-1-git-send-email-yrobot@amazon.com> <20151021105903.GC16140@bricha3-MOBL3> In-Reply-To: <20151021105903.GC16140@bricha3-MOBL3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] lib: rte_*_create gives NULL/EEXIST on duped name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 12:06:01 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, October 21, 2015 11:59 AM > To: Yoni Fogel > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib: rte_*_create gives NULL/EEXIST on du= ped name >=20 > On Tue, Oct 20, 2015 at 01:21:37PM -0700, Yoni Fogel wrote: > > Also fixed a bug in many of them where if the rte_malloc of > > the TAILQ fails, then we return a pointer to some arbitrary > > existing struct. Another nit - please don't forget to update comments in the .h files, about= changed behaviour. Konstantin > > > > Signed-off-by: Yoni Fogel >=20 > Thanks, looks like good fixes. However, I think for fixes like these they= are > better as one-fix-per-patch, because in this case we have the title refer= ring > to one fix, while the comment log describes a completely separate fix. > Can you perhaps do a V2 as a two-patch set? >=20 > /Bruce >=20 > > --- > > lib/librte_acl/rte_acl.c | 53 +++++++++++++++++++++----------= -------- > > lib/librte_hash/rte_cuckoo_hash.c | 6 +++-- > > lib/librte_hash/rte_fbk_hash.c | 5 +++- > > lib/librte_lpm/rte_lpm.c | 5 +++- > > lib/librte_lpm/rte_lpm6.c | 5 +++- > > 5 files changed, 44 insertions(+), 30 deletions(-) > >