From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1CA2E5A5D for ; Tue, 27 Oct 2015 13:12:43 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 27 Oct 2015 05:12:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,204,1444719600"; d="scan'208";a="672647236" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 27 Oct 2015 05:12:42 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by IRSMSX107.ger.corp.intel.com ([169.254.10.49]) with mapi id 14.03.0248.002; Tue, 27 Oct 2015 12:12:40 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , "Traynor, Kevin" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: change logging for ixgbe tx code path selection Thread-Index: AQHREK2zibMlnQmfOEGnergE82LbeZ5/P9Zg Date: Tue, 27 Oct 2015 12:12:39 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836AB5666@irsmsx105.ger.corp.intel.com> References: <1445946068-28183-1-git-send-email-kevin.traynor@intel.com> <20151027115003.GA7500@bricha3-MOBL3> In-Reply-To: <20151027115003.GA7500@bricha3-MOBL3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: change logging for ixgbe tx code path selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2015 12:12:44 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, October 27, 2015 11:50 AM > To: Traynor, Kevin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: change logging for ixgbe tx code p= ath selection >=20 > On Tue, Oct 27, 2015 at 11:41:08AM +0000, Kevin Traynor wrote: > > Simple and vector are different tx code paths. If vector > > is selected, change logging from: > > PMD: ixgbe_set_tx_function(): Using simple tx code path > > PMD: ixgbe_set_tx_function(): Vector tx enabled. > > > > to: > > PMD: ixgbe_set_tx_function(): Using vector tx code path > > > > or, if simple selected: > > PMD: ixgbe_set_tx_function(): Using simple tx code path > > > > The dangling else in the #ifdef makes readability difficult, > > so resolving in way that seems most readable. > > > > Signed-off-by: Kevin Traynor > > --- > > drivers/net/ixgbe/ixgbe_rxtx.c | 8 +++++--- > > 1 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_r= xtx.c > > index a598a72..11d7feb 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -1963,16 +1963,18 @@ ixgbe_set_tx_function(struct rte_eth_dev *dev, = struct ixgbe_tx_queue *txq) > > /* Use a simple Tx queue (no offloads, no multi segs) if possible */ > > if (((txq->txq_flags & IXGBE_SIMPLE_FLAGS) =3D=3D IXGBE_SIMPLE_FLAGS) > > && (txq->tx_rs_thresh >=3D RTE_PMD_IXGBE_TX_MAX_BURST)) { > > - PMD_INIT_LOG(DEBUG, "Using simple tx code path"); > > #ifdef RTE_IXGBE_INC_VECTOR > > if (txq->tx_rs_thresh <=3D RTE_IXGBE_TX_MAX_FREE_BUF_SZ && > > (rte_eal_process_type() !=3D RTE_PROC_PRIMARY || > > ixgbe_txq_vec_setup(txq) =3D=3D 0)) { > > - PMD_INIT_LOG(DEBUG, "Vector tx enabled."); > > + PMD_INIT_LOG(DEBUG, "Using vector tx code path"); > > dev->tx_pkt_burst =3D ixgbe_xmit_pkts_vec; > > } else > > #endif > > - dev->tx_pkt_burst =3D ixgbe_xmit_pkts_simple; > > + { > > + PMD_INIT_LOG(DEBUG, "Using simple tx code path"); > > + dev->tx_pkt_burst =3D ixgbe_xmit_pkts_simple; > > + } > > } else { > > PMD_INIT_LOG(DEBUG, "Using full-featured tx code path"); > > PMD_INIT_LOG(DEBUG, > > -- > > 1.7.4.1 > > > Hi Kevin, >=20 > can I suggest a slight alternative here that might help make things easie= r. > Instead of printing the message as we pick the code path, why not have a = "logmsg" > pointer variable that is assigned in the code, and then print out the log= path > at the end. >=20 > This would have a number of advantages: > 1. there are no issues with changing our mind, so we can assign one path = type, > and then later change it to something different without cluttering up the= debug > output with the history of our code's flow. > 2. it means that you don't have a problem with smaller else legs as you c= an > easily do multiple assignments in the one line using a comma as: > dev->tx_pkt_burst =3D ixgbe_xmit_pkts_simple, logmsg =3D "Using simple .= .."; While I like approach with logmsg, please avoid commas here. It will make this peace of code even more hard to read (at least for me). Konstantin=20 >=20 > Regards, > /Bruce