Re: [dpdk-dev] [PATCHv7 7/9] vmxnet3: add HW specific desc_lim data into dev_info

["Ananyev, Konstantin" <konstantin.ananyev@intel.com>]

Hi

> -----Original Message-----
> From: Yong Wang [mailto:yongwang@vmware.com]
> Sent: Saturday, October 31, 2015 8:55 AM
> To: Ananyev, Konstantin; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCHv7 7/9] vmxnet3: add HW specific desc_lim data into dev_info
> 
> On 10/27/15, 5:51 AM, "Konstantin Ananyev" <konstantin.ananyev@intel.com> wrote:
> 
> 
> >Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> >---
> 
> Acked-by: Yong Wang <yongwang@vmware.com>
> 
> Do you plan to implement rxq_info_get and txq_info_get for vmxnet3 in subsequent patches?

I might, though my hope is that engineers who are familiar with particular PMDs will
pick it up and add support for (rxq|txq)_get_info() remaining PMDs.
So if you feel like that, please don't hesitate :)
Thanks
Konstantin 

> 
> > drivers/net/vmxnet3/vmxnet3_ethdev.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> >diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> >index a70be5c..3745b7d 100644
> >--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> >+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> >@@ -677,6 +677,18 @@ vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev, struct rte_
> > 	dev_info->default_txconf.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
> > 						ETH_TXQ_FLAGS_NOOFFLOADS;
> > 	dev_info->flow_type_rss_offloads = VMXNET3_RSS_OFFLOAD_ALL;
> >+
> >+	dev_info->rx_desc_lim = (struct rte_eth_desc_lim) {
> >+		.nb_max = VMXNET3_RX_RING_MAX_SIZE,
> >+		.nb_min = VMXNET3_DEF_RX_RING_SIZE,
> >+		.nb_align = 1,
> >+	};
> >+
> >+	dev_info->tx_desc_lim = (struct rte_eth_desc_lim) {
> >+		.nb_max = VMXNET3_TX_RING_MAX_SIZE,
> >+		.nb_min = VMXNET3_DEF_TX_RING_SIZE,
> >+		.nb_align = 1,
> >+	};
> > }
> >
> > /* return 0 means link status changed, -1 means not changed */
> >--
> >1.8.5.3
> >