From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id CE60A8E8C for ; Tue, 3 Nov 2015 14:21:01 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 03 Nov 2015 05:21:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,238,1444719600"; d="scan'208";a="841494551" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga002.jf.intel.com with ESMTP; 03 Nov 2015 05:21:00 -0800 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Nov 2015 13:20:59 +0000 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by IRSMSX156.ger.corp.intel.com ([169.254.3.245]) with mapi id 14.03.0248.002; Tue, 3 Nov 2015 13:20:59 +0000 From: "Ananyev, Konstantin" To: Jan Viktorin Thread-Topic: [PATCH 2/3] arm64: acl: add neon based acl implementation Thread-Index: AQHRFXmY1zN5Lln6OkywaSyh4UxBO56I8ckggADEH4CAAGDnQIAABQwAgAApKbA= Date: Tue, 3 Nov 2015 13:20:58 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836AB8CD1@irsmsx105.ger.corp.intel.com> References: <1446473921-12706-1-git-send-email-jerin.jacob@caviumnetworks.com> <1446473921-12706-2-git-send-email-jerin.jacob@caviumnetworks.com> <1446473921-12706-3-git-send-email-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB97725836AB86A5@irsmsx105.ger.corp.intel.com> <20151103043051.GA2228@localhost.localdomain> <2601191342CEEE43887BDE71AB97725836AB8AA2@irsmsx105.ger.corp.intel.com> <20151103113548.3c7d4224@jvn> In-Reply-To: <20151103113548.3c7d4224@jvn> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/3] arm64: acl: add neon based acl implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 13:21:02 -0000 > -----Original Message----- > From: Jan Viktorin [mailto:viktorin@rehivetech.com] > Sent: Tuesday, November 03, 2015 10:36 AM > To: Ananyev, Konstantin > Cc: Jerin Jacob; dev@dpdk.org; thomas.monjalon@6wind.com; Hunt, David > Subject: Re: [PATCH 2/3] arm64: acl: add neon based acl implementation >=20 > On Tue, 3 Nov 2015 10:23:55 +0000 > "Ananyev, Konstantin" wrote: >=20 > > > Hi Konstantin, > > > > > > > > On ARM, is there any specific cpu flag that you can use to determin= e is NEON > > > > isa is supported or not? > > > > > > Yes, on armv7(RTE_CPUFLAG_NEON). On armv8-a NEON is mandatory. > > > > > > > It would be good to avoid extra conditional compilation here if pos= sible. > > > neon acl is verified/ported only on armv8. While adding the armv7 sup= port the > > > check can be extended for cpuflag based on RTE_CPUFLAG_NEON on armv7 > > > > Ok, and is there a flag that allows to distinguish between armv7 and ar= m8 then at runtime? > > It is probably ok like that, but with all that conditional compilations= it gets too messy. > > Another thing - if you can distinguish between armv7 and armv8 at runti= me, then you probably > > can set alg =3D RTE_ACL_CLASSIFY_DEFAULT for armv7 and alg =3D RTE_ACL_= CLASSIFY_NEON for arm8? > > Konstantin >=20 > The ARMv7 provides "v7l" in the AT_PLATFORM and the ARMv8 gives > "aarach64". However, I am afraid, as these are two distinct platforms > (with distinct cpuflags), we cannot use the cpuflags easily for this. >=20 Ok, if you think it is unavoidable - let's keep it like that for now. > Is there an API in DPDK which allows to ask globally: "what platform am > I running on?"? Not that I am aware about. Konstantin >=20 > Jan >=20 > > > > > > > > > Another question - did I get it right that NEON isa is supported on= all > > > > possible RTE_ARCH_ARM64 cpu models you plan to support? > > > > > > Yes >=20 >=20 > -- > Jan Viktorin E-mail: Viktorin@RehiveTech.com > System Architect Web: www.RehiveTech.com > RehiveTech > Brno, Czech Republic