From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7DBC1902 for ; Fri, 20 Nov 2015 13:04:11 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 20 Nov 2015 04:04:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,322,1444719600"; d="scan'208";a="843316576" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 20 Nov 2015 04:04:10 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.203]) by IRSMSX102.ger.corp.intel.com ([169.254.2.251]) with mapi id 14.03.0248.002; Fri, 20 Nov 2015 12:04:08 +0000 From: "Ananyev, Konstantin" To: "Van Haaren, Harry" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters Thread-Index: AQHRIe60FH+VgPFHz0SHSrZSffLEtZ6k0xRA Date: Fri, 20 Nov 2015 12:04:07 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836ACA81F@irsmsx105.ger.corp.intel.com> References: <1447670117-17723-1-git-send-email-harry.van.haaren@intel.com> <1447843689-32315-1-git-send-email-harry.van.haaren@intel.com> In-Reply-To: <1447843689-32315-1-git-send-email-harry.van.haaren@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "shemming@brocade.com" Subject: Re: [dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2015 12:04:11 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren > Sent: Wednesday, November 18, 2015 10:48 AM > To: dev@dpdk.org > Cc: shemming@brocade.com > Subject: [dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters >=20 > This patchset removes CRC bytes from byte statistics in the following > PMDs: igb, ixgbe, i40e. >=20 > This brings the reported byte statistics in-line with other NICs, > providing consistency. >=20 > Removing the CRC from byte counters in i40e resolves a bug, see > i40e commit message for details. >=20 > v2: > -Done Stephen Hemmingers suggestion of ETHER_CRC_LEN replacing magic #4 > -Removed fm10k patch, thanks Michael Qiu for reporting - my testpmd usage > for packet sizes on fm10k was creating an offset of 4 bytes in testing. > -Reworded some comments >=20 >=20 > Harry van Haaren (3): > e1000: remove crc size from all byte counters > ixgbe: remove crc size from all byte counters > i40e: fix rx/tx size mismatch, remove crc bytes >=20 > drivers/net/e1000/igb_ethdev.c | 19 ++++++++++++-- > drivers/net/i40e/i40e_ethdev.c | 13 ++++++++-- > drivers/net/ixgbe/ixgbe_ethdev.c | 55 +++++++++++++++++++++++++++++++---= ------ > 3 files changed, 71 insertions(+), 16 deletions(-) >=20 Acked-by: Konstantin Ananyev > -- > 1.9.1