From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <konstantin.ananyev@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 65A802E8D for <dev@dpdk.org>; Fri, 27 Nov 2015 13:35:47 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 27 Nov 2015 04:35:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,351,1444719600"; d="scan'208";a="860469528" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 27 Nov 2015 04:35:44 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.203]) by IRSMSX102.ger.corp.intel.com ([169.254.2.251]) with mapi id 14.03.0248.002; Fri, 27 Nov 2015 12:34:01 +0000 From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> To: "Qiu, Michael" <michael.qiu@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com> Thread-Topic: [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4 Thread-Index: AQHRKQpbzWQPg8M5Z0KzSO/QK3W11Z6vy+3Q Date: Fri, 27 Nov 2015 12:34:00 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836ACDA70@irsmsx105.ger.corp.intel.com> References: <1448534997-24297-1-git-send-email-michael.qiu@intel.com> <40264692.U54vlS2tjY@xps13> <533710CFB86FA344BFBF2D6802E6028621B8CCF5@SHSMSX101.ccr.corp.intel.com> <14808329.F48z9c4v47@xps13> <4BFDBCEE-D3A0-4C2F-8F78-8A7CD1FF08B6@intel.com> In-Reply-To: <4BFDBCEE-D3A0-4C2F-8F78-8A7CD1FF08B6@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 27 Nov 2015 12:35:48 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiu, Michael > Sent: Friday, November 27, 2015 11:53 AM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.= 3.4 >=20 > really=1B$B!)=1B(BI don't think so. >=20 > AVX Marco only exist in the gcc version below 4.4, I still need to check= if below or beyond 4.4 am I right? >=20 > Thanks, > Michael If you look at lib/librte_eal/common/include/arch/x86/rte_vect.h, you'll se= e the code similar to one you are trying to put into rte_shed.c: lib/librte_eal/common/include/arch/x86/rte_vect.h: ... #if (defined(__ICC) || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ < 4)) #ifdef __SSE__ #include <xmmintrin.h> #endif #ifdef __SSE2__ #include <emmintrin.h> #endif #ifdef __SSE3__ #include <tmmintrin.h> #endif #if defined(__SSE4_2__) || defined(__SSE4_1__) #include <smmintrin.h> #endif #if defined(__AVX__) #include <immintrin.h> #endif #else #include <x86intrin.h> #endif ... So I think you can do just like that: #include <rte_vect.h> #if defined(__AVX__) #define SCHED_VECTOR_ENABLE #endif inside rte_sched.c Konstantin >=20 >=20 > > =1B$B:_=1B(B 2015=1B$BG/=1B(B11=1B$B7n=1B(B27=1B$BF|!$2<8a=1B(B5:01=1B$= B!$=1B(BThomas Monjalon <thomas.monjalon@6wind.com> =1B$B<LF;!'=1B(B > > > > 2015-11-27 02:26, Qiu, Michael: > >>> On 2015/11/27 5:29, Thomas Monjalon wrote: > >>> 2015-11-26 18:49, Michael Qiu: > >>>> gcc 4.3.4 does not include "immintrin.h", and will post below error: > >>>> lib/librte_sched/rte_sched.c:56:23: error: > >>>> immintrin.h: No such file or directory > >>>> > >>>> To avoid this issue, a gcc version check is need and a flag to indic= ate > >>>> vector ablility. > >>> [...] > >>>> +#if (defined(__ICC) || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ < 4)) > >>>> + > >>>> +#if defined(__AVX__) > >>>> #include <immintrin.h> > >>>> +#define SCHED_VECTOR_ENABLE > >>>> +#endif > >>>> + > >>>> +#else > >>>> + > >>>> +#include <x86intrin.h> > >>>> +#define SCHED_VECTOR_ENABLE > >>>> + > >>>> +#endif > >>> This kind of complication is managed by EAL. > >>> I think we should include rte_vect.h. > >> > >> As I know here it needs a flag to identify whether the platform suppor= t > >> AVX, if not it will not use it, so I don't know if we could only simpl= y > >> include rte_vect.h? > > > > It's not exclusive. > > You can include rte_vect.h and check AVX to define SCHED_VECTOR_ENABLE. > >