From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 13811C486
 for <dev@dpdk.org>; Thu, 28 Jan 2016 14:57:07 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP; 28 Jan 2016 05:57:07 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,358,1449561600"; d="scan'208";a="900158014"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by orsmga002.jf.intel.com with ESMTP; 28 Jan 2016 05:57:08 -0800
Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by
 IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 28 Jan 2016 13:57:05 +0000
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.237]) by
 irsmsx155.ger.corp.intel.com ([169.254.14.217]) with mapi id 14.03.0248.002;
 Thu, 28 Jan 2016 13:57:05 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Horton, Remy"
 <remy.horton@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control interface library
Thread-Index: AQHRWb0yBdSDudnnokagvJjklgBL0Z8Q6E0AgAALQpA=
Date: Thu, 28 Jan 2016 13:57:04 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836AFFCC8@irsmsx105.ger.corp.intel.com>
References: <1453911849-16562-1-git-send-email-ferruh.yigit@intel.com>
 <1453911849-16562-3-git-send-email-ferruh.yigit@intel.com>
 <56A9F827.1060403@intel.com>
 <20160128131500.GA16492@sivlogin002.ir.intel.com>
In-Reply-To: <20160128131500.GA16492@sivlogin002.ir.intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control
	interface	library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2016 13:57:08 -0000

Hi Ferruh,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Thursday, January 28, 2016 1:15 PM
> To: Horton, Remy
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control interface li=
brary
>=20
> On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote:
> > On 27/01/2016 16:24, Ferruh Yigit wrote:
> >
> > > +	default:
> > > +		ret =3D -95 /* EOPNOTSUPP */;
> > > +		break;
> >
> > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK)..
> >
> Return value is not significant, callee just checks for negative value,
> I can remove comment to prevent confusion.

Please use values defined in errno.h, there are plenty of them,
no need to invent your own error codes.
Also pls don't forget to address all comments I gave you offline.
Thanks
Konstantin

>=20
> Thanks,
> ferruh