From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 286CDC5FA for ; Fri, 29 Jan 2016 11:17:44 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 29 Jan 2016 02:17:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,363,1449561600"; d="scan'208";a="38418155" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga004.fm.intel.com with ESMTP; 29 Jan 2016 02:17:44 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.237]) by IRSMSX154.ger.corp.intel.com ([169.254.12.208]) with mapi id 14.03.0248.002; Fri, 29 Jan 2016 10:17:39 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v7 3/5] ethdev: redesign link speed config API Thread-Index: AQHRWi4WGum0DGIU/UKSxVrGvIzUkZ8SN6AAgAAFWwCAAACY4IAAA/WAgAAFnvA= Date: Fri, 29 Jan 2016 10:17:38 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B0014E@irsmsx105.ger.corp.intel.com> References: <1445810400-8978-1-git-send-email-marcdevel@gmail.com> <1745156.01DTmyzyO8@xps13> <2601191342CEEE43887BDE71AB97725836B000EC@irsmsx105.ger.corp.intel.com> <14139435.dXsMv1AF6J@xps13> In-Reply-To: <14139435.dXsMv1AF6J@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 3/5] ethdev: redesign link speed config API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2016 10:17:44 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, January 29, 2016 9:54 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Marc Sune; Lu, Wenzhuo; Zhang, Helin; Harish Patil; Che= n, Jing D; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH v7 3/5] ethdev: redesign link speed config= API >=20 > 2016-01-29 09:47, Ananyev, Konstantin: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-01-29 09:24, Ananyev, Konstantin: > > > > Can you avoid modifications in the e1000/base code? > > > > We do not modify (and maintain) that part on our own. > > > > Instead we take it straight from Intel ND. > > > > So if you feel like these changes are really necessary - please sub= mit a patch > > > > to ND first, and if your changes will be applied, will pick it up f= rom them. > > > > > > I was not aware we can submit a change to ND for Intel base drivers. > > > What is the procedure please? > > > > I meant not to the ND directly, but probably to the freebsd e1000 kerne= l driver. > > As I remember, that is the closest one to what we have. > > From my understanding (I might be wrong here): > > If they will be accepted, we should see these changes In next code drop= s from ND. >=20 > These base drivers are used in several places. > We are allowed to submit a patch in Linux or FreeBSD but not in DPDK > where the base driver is verbatim? Yes, that's my understanding. > We have an agreement to not touch them in DPDK Yes. > but I still think the > ND team could consider some patches from dpdk.org. I personally think that would be a good thing, but it is up to ND guys to make such decision. =20 Konstantin