From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7DF432BA7 for ; Wed, 24 Feb 2016 11:22:11 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 24 Feb 2016 02:22:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,493,1449561600"; d="scan'208";a="910132963" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 24 Feb 2016 02:22:09 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.237]) by IRSMSX101.ger.corp.intel.com ([169.254.1.157]) with mapi id 14.03.0248.002; Wed, 24 Feb 2016 10:22:09 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension Thread-Index: AQHRbuuqRgAEfJvnOEGcN5HzlAMBcZ86+prw Date: Wed, 24 Feb 2016 10:22:08 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B0AAF3@irsmsx105.ger.corp.intel.com> References: <91026831.UvMIbM9v17@xps13> <2221343.vDGpEpgp97@xps13> <20160224101011.GA19784@bricha3-MOBL3> In-Reply-To: <20160224101011.GA19784@bricha3-MOBL3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTBlMjAzNzktNGJkMi00OWQzLWE4YmItN2UwMjg5MGFmNGNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBuKzVKNUphQTNTN2dtSitmb1Jadm9ndzFUV3BkXC9QdXVjZnNhYTVIREE4PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Kantecki, Tomasz" Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 10:22:12 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, February 24, 2016 10:10 AM > To: Thomas Monjalon > Cc: dev@dpdk.org; Kantecki, Tomasz > Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL e= xtension >=20 > On Wed, Feb 24, 2016 at 09:24:33AM +0100, Thomas Monjalon wrote: > > 2016-02-23 23:03, Kantecki, Tomasz: > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > If there is nothing specific in DPDK for PQos, why writing an examp= le in > > > > DPDK? > > > The example makes it much easier to use the technology with DPDK. > > > > > > > Maybe the example should be better in the library itself. > > > The library in question (https://github.com/01org/intel-cmt-cat) has = a couple of examples but none of them refers to DPDK. > > > > > > > I suggest to mention the library in > > > > doc/guides/linux_gsg/nic_perf_intel_platform.rst > > > Ok it can be added to this document. Does it imply -1 for the sample = code idea? > > > > I may be wrong but I have the feeling the example is more about PQoS th= an DPDK. > > So yes, I would vote -1. > > > Well, the intersection of DPDK and PQoS is what the example is really all= about, > and as such it is relevant to both DPDK and the library itself. Platform = QoS > can be of great use to packet processing applications for helping to ensu= re that > the app gets the resources it needed - especially in a virtualised world = - and > so we believe that having an example in DPDK showing how to use PQoS with= DPDK > is well worthwhile having. It's more effective than a simple doc update i= n > raising awareness of the existence of the feature, and also provides for = DPDK > users a readily available app for the user to start playing with to evalu= ate > PQoS for their own use-cases. +1=20 I also think it is a good thing to have. Again user don't have to trust the whitepapers - instead he can run the app= =20 and measure performance gain on his particular platform. Konstantin =20 > I also fail to see what the downside of having the sample app is - it won= 't add > significantly to the project maintenance overhead. >=20 > Regards, > /Bruce