From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 03FB02B98 for ; Wed, 24 Feb 2016 12:21:33 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 24 Feb 2016 03:21:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,493,1449561600"; d="scan'208";a="893550037" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 24 Feb 2016 03:21:32 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.237]) by IRSMSX103.ger.corp.intel.com ([169.254.3.239]) with mapi id 14.03.0248.002; Wed, 24 Feb 2016 11:21:31 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension Thread-Index: AQHRbuuqRgAEfJvnOEGcN5HzlAMBcZ86+prwgAAFiwCAAArAIA== Date: Wed, 24 Feb 2016 11:21:30 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B0AB6C@irsmsx105.ger.corp.intel.com> References: <20160224101011.GA19784@bricha3-MOBL3> <2601191342CEEE43887BDE71AB97725836B0AAF3@irsmsx105.ger.corp.intel.com> <1520606.5uKYNpmzaU@xps13> In-Reply-To: <1520606.5uKYNpmzaU@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzQyMjQwODctOTViYy00ZTY2LTg1NDgtOTMyMzVkYzA3MzE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImhkUHc0OXhsdnVyYzg0VHhSVGNQZUpoM2NySmRDU0dHTVB5Smh6OGh2SlU9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Kantecki, Tomasz" Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 11:21:34 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, February 24, 2016 10:35 AM > To: Ananyev, Konstantin > Cc: Richardson, Bruce; dev@dpdk.org; Kantecki, Tomasz > Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL e= xtension >=20 > 2016-02-24 10:22, Ananyev, Konstantin: > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > > Sent: Wednesday, February 24, 2016 10:10 AM > > > To: Thomas Monjalon > > > Cc: dev@dpdk.org; Kantecki, Tomasz > > > Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS E= AL extension > > > > > > On Wed, Feb 24, 2016 at 09:24:33AM +0100, Thomas Monjalon wrote: > > > > 2016-02-23 23:03, Kantecki, Tomasz: > > > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > > If there is nothing specific in DPDK for PQos, why writing an e= xample in > > > > > > DPDK? > > > > > The example makes it much easier to use the technology with DPDK. > > > > > > > > > > > Maybe the example should be better in the library itself. > > > > > The library in question (https://github.com/01org/intel-cmt-cat) = has a couple of examples but none of them refers to DPDK. > > > > > > > > > > > I suggest to mention the library in > > > > > > doc/guides/linux_gsg/nic_perf_intel_platform.rst > > > > > Ok it can be added to this document. Does it imply -1 for the sam= ple code idea? > > > > > > > > I may be wrong but I have the feeling the example is more about PQo= S than DPDK. > > > > So yes, I would vote -1. > > > > > > > Well, the intersection of DPDK and PQoS is what the example is really= all about, > > > and as such it is relevant to both DPDK and the library itself. Platf= orm QoS > > > can be of great use to packet processing applications for helping to = ensure that > > > the app gets the resources it needed - especially in a virtualised wo= rld - and > > > so we believe that having an example in DPDK showing how to use PQoS = with DPDK > > > is well worthwhile having. It's more effective than a simple doc upda= te in > > > raising awareness of the existence of the feature, and also provides = for DPDK > > > users a readily available app for the user to start playing with to e= valuate > > > PQoS for their own use-cases. > > > > +1 > > I also think it is a good thing to have. > > Again user don't have to trust the whitepapers - instead he can run the= app > > and measure performance gain on his particular platform. >=20 > I totally agree the example is good to have. > Konstantin, are you thinking it must be hosted in the PQoS lib repository= ? Personally I prefer it to be part of dpdk samples. DPDK IO code path is a bit different from what the 'classical' user app usu= ally does - a lot of polling, avoid system calls, etc. Also it would probably have much better visibility here. Again, as Bruce already mentioned, we have QAT & TAP samples, why we can't= have PQoS too. Konstantin