From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 15C6637B2
 for <dev@dpdk.org>; Fri, 26 Feb 2016 15:27:25 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 26 Feb 2016 06:27:24 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="659744229"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by FMSMGA003.fm.intel.com with ESMTP; 26 Feb 2016 06:27:23 -0800
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.237]) by
 IRSMSX101.ger.corp.intel.com ([169.254.1.157]) with mapi id 14.03.0248.002;
 Fri, 26 Feb 2016 14:27:23 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v4 12/12] examples/l3fwd: add option to parse ptype
Thread-Index: AQHRcGTtIifTLhAFr0u9onp+cs1LHJ8+MTyggAAv1ICAAAFBAA==
Date: Fri, 26 Feb 2016 14:27:22 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836B0BBA1@irsmsx105.ger.corp.intel.com>
References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com>
 <1456445371-147264-1-git-send-email-jianfeng.tan@intel.com>
 <1456445371-147264-13-git-send-email-jianfeng.tan@intel.com>
 <2601191342CEEE43887BDE71AB97725836B0BB05@irsmsx105.ger.corp.intel.com>
 <56D05F51.5020806@intel.com>
In-Reply-To: <56D05F51.5020806@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2IwYjFjZjgtNWNjZi00MTI0LTk5NjYtZjc0MDFjNjQ3OWMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImFuYkdzOUdLcGFqMG1lSE9wU1diT2E0TVpGRXc3ajNwejZvYXM2MjBwa2M9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4 12/12] examples/l3fwd: add option to parse
	ptype
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Feb 2016 14:27:26 -0000

> > Actually it is a good point:
> > for EM case should l3fwd process only TCP/UDP packets?
> > If yes, then it needs to check not only L3, but also L4 type too
> > Which means that for EM and LPM check_packet_type_ok() should also be d=
ifferent.
> > Or we can leave it as it is - in that case EM even for non UDP/TCP pack=
et would still
> > do route  lookup using first 4B of L3 payload.
>=20
> I'd like to follow the first approach, (if nobody strongly objects to
> it), because it's EM's real intention to use 5 tuples.

Ok with me.
Konstantin