From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4DF6F2BCD for ; Fri, 1 Apr 2016 14:28:13 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP; 01 Apr 2016 05:28:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,427,1455004800"; d="scan'208";a="776155146" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 01 Apr 2016 05:28:11 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.35]) by IRSMSX104.ger.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0248.002; Fri, 1 Apr 2016 13:28:10 +0100 From: "Ananyev, Konstantin" To: "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [PATCH] igb: fix i350 VF RX issue Thread-Index: AQHRi7t1wwnE/DEdkUKJ0T8UiRY5QZ91DBsw Date: Fri, 1 Apr 2016 12:28:08 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B232D8@irsmsx105.ger.corp.intel.com> References: <1459476534-7624-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1459476534-7624-1-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTdjNzYxYTEtMzZjNi00OWE5LTg3MjQtM2IzOTg3OTk1ZjU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IklFYkc1MDZPcXhhYloweEpacjNcL0NMMVJCRmVWK3RTZkFwUWVJTzl0NjFzPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igb: fix i350 VF RX issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 12:28:13 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Friday, April 01, 2016 3:09 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: [PATCH] igb: fix i350 VF RX issue >=20 > A problem is found on i350 VF. We found TX will happen once > per 4 packets. If only 1~3 packets are received, they will > not be forwarded. But the real problem is on RX side. The > reason is the default RX write-back threshold is changed to > 4, so every first 3 packets may be hung there. >=20 > This patch checks the RX wthresh when setting up the RX > queue, and forces it to be 1, so every packet can be handled > immediately. >=20 > Fixes: 4a41c17dba18 (igb: set default thresholds based on MAC type) > --- > drivers/net/e1000/igb_rxtx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c > index 529dba4..4a987e3 100644 > --- a/drivers/net/e1000/igb_rxtx.c > +++ b/drivers/net/e1000/igb_rxtx.c > @@ -1466,7 +1466,8 @@ eth_igb_rx_queue_setup(struct rte_eth_dev *dev, > rxq->pthresh =3D rx_conf->rx_thresh.pthresh; > rxq->hthresh =3D rx_conf->rx_thresh.hthresh; > rxq->wthresh =3D rx_conf->rx_thresh.wthresh; > - if (rxq->wthresh > 0 && hw->mac.type =3D=3D e1000_82576) > + if (rxq->wthresh > 0 && > + (hw->mac.type =3D=3D e1000_82576 || hw->mac.type =3D=3D e1000_vfada= pt_i350)) > rxq->wthresh =3D 1; > rxq->drop_en =3D rx_conf->rx_drop_en; > rxq->rx_free_thresh =3D rx_conf->rx_free_thresh; > -- Acked-by: Konstantin Ananyev > 1.9.3