From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 96B7B2A5D for ; Mon, 25 Apr 2016 14:02:16 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 25 Apr 2016 05:02:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,532,1455004800"; d="scan'208";a="939622141" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 25 Apr 2016 05:02:13 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 25 Apr 2016 13:02:12 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.35]) by irsmsx111.ger.corp.intel.com ([169.254.2.16]) with mapi id 14.03.0248.002; Mon, 25 Apr 2016 13:02:12 +0100 From: "Ananyev, Konstantin" To: "'John Daley (johndale)'" , "dev@dpdk.org" Thread-Topic: PKT_RX_VLAN_PKT when VLAN stripping is disabled Thread-Index: AdGcJLb1bs00/Tr/R5uEj1zfkCb1SAAbv2nQ Date: Mon, 25 Apr 2016 12:02:11 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B415A3@irsmsx105.ger.corp.intel.com> References: <55ece514189d46d59cca2217214d89be@XCH-RCD-007.cisco.com> In-Reply-To: <55ece514189d46d59cca2217214d89be@XCH-RCD-007.cisco.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjM1ZGJiM2MtMzcxMC00YzVkLWFjMDktYTk3Mjg3YTE2MDhmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InplXC9CZmpQRDZ5bGhHT3ZaMFhoTjQrXC9DUmx1SE52MXFmYkk0M2Q1YUx6cz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2016 12:02:17 -0000 Hi John, >>From rte_mbuf.h: #define PKT_RX_VLAN_PKT (1ULL << 0) /**< RX packet is a 802.1q VLAN p= acket. */ So yes, in theory it should be set up for vlan packet with both stripping o= n/off. The problem is that (as far as I know) when VLAN stripping is disabled FVL= RXD doesn't contain information does that packet contain a VLAN or not. Don't really know what is the best option in that case: keep things as it i= s or change the meaning of the VLAN_PKT flag to indicate is mbuf.vlan_tci field is valid or not. Konstantin=20 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Daley (johndale= ) > Sent: Friday, April 22, 2016 12:37 AM > To: dev@dpdk.org > Subject: [dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled >=20 > Hi, >=20 > When VLAN stripping is disabled, X710 and 82599ES act differently for me = in this case when receiving VLAN tagged packets. On > 82599ES the flag is set but on X710 the flag not set. >=20 > Do I maybe have old X710 firmware? Or is it not set for X710 on purpose i= n this case and instead the flag is used to indicate if vlan_tci is > valid? Right now the enic pmd does what my X710 does, which I think is in= correct and I want to fix it. >=20 > Thanks, > John