From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3FC915AA9 for ; Mon, 23 May 2016 11:23:22 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 23 May 2016 02:23:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,354,1459839600"; d="scan'208";a="986733206" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 23 May 2016 02:23:20 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.27]) by IRSMSX154.ger.corp.intel.com ([169.254.12.18]) with mapi id 14.03.0248.002; Mon, 23 May 2016 10:23:18 +0100 From: "Ananyev, Konstantin" To: Olivier Matz , "dev@dpdk.org" CC: "johndale@cisco.com" , "Zhang, Helin" , "adrien.mazarguil@6wind.com" , "rahul.lakkireddy@chelsio.com" , "alejandro.lucero@netronome.com" , "sony.chacko@qlogic.com" Thread-Topic: [PATCH] mbuf: new flag when Vlan is stripped Thread-Index: AQHRtM/PhEApRKY/Yk+xvqrmesFPo5/GOMWQ///zZYCAABEZ0A== Date: Mon, 23 May 2016 09:23:17 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B5CACB@irsmsx105.ger.corp.intel.com> References: <1462897493-6567-1-git-send-email-olivier.matz@6wind.com> <1463993205-5623-1-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725836B5CA88@irsmsx105.ger.corp.intel.com> <5742C991.7090808@6wind.com> In-Reply-To: <5742C991.7090808@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mbuf: new flag when Vlan is stripped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2016 09:23:22 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Monday, May 23, 2016 10:13 AM > To: Ananyev, Konstantin; dev@dpdk.org > Cc: johndale@cisco.com; Zhang, Helin; adrien.mazarguil@6wind.com; rahul.l= akkireddy@chelsio.com; > alejandro.lucero@netronome.com; sony.chacko@qlogic.com > Subject: Re: [PATCH] mbuf: new flag when Vlan is stripped >=20 > Hi Konstantin, >=20 > On 05/23/2016 10:59 AM, Ananyev, Konstantin wrote: > > Hi Olivier, > > > >> -----Original Message----- > >> From: Olivier Matz [mailto:olivier.matz@6wind.com] > >> Sent: Monday, May 23, 2016 9:47 AM > >> To: dev@dpdk.org > >> Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; adrien.maza= rguil@6wind.com; rahul.lakkireddy@chelsio.com; > >> alejandro.lucero@netronome.com; sony.chacko@qlogic.com > >> Subject: [PATCH] mbuf: new flag when Vlan is stripped > >> > >> The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting i= n > >> PMDs not advertising the same flags in similar conditions. > >> > >> Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPE= D > >> and PKT_RX_QINQ_STRIPPED that are better defined: > >> > >> PKT_RX_VLAN_STRIPPED: a vlan has been stripped by the hardware and i= ts > >> tci is saved in mbuf->vlan_tci. This can only happen if vlan strippi= ng > >> is enabled in the RX configuration of the PMD. > >> > >> For now, the old flag PKT_RX_VLAN_PKT is kept but marked as deprecated= . > >> It should be removed from applications and PMDs in a future revision. > >> > >> This patch also updates the drivers. For PKT_RX_VLAN_PKT: > >> > >> - e1000, enic, i40e, mlx5, nfp, vmxnet3: done, PKT_RX_VLAN_PKT already > >> had the same meaning than PKT_RX_VLAN_STRIPPED, minor update is > >> required. > >> - fm10k: done, PKT_RX_VLAN_PKT already had the same meaning than > >> PKT_RX_VLAN_STRIPPED, and vlan stripping is always enabled on fm10k. > >> - ixgbe: modification done for standard mode (vector does not support > >> vlan stripping) > >> - the other drivers do not support vlan stripping. > >> > >> For PKT_RX_QINQ_PKT, it was only supported on i40e, and the meaning wa= s > >> already correct, so we can reuse the same value for PKT_RX_QINQ_STRIPP= ED. > >> > > > > I don't see ixgbe/i4oe_rxtx_vec.c updated. > > Would it be another patch for them? >=20 > The ixgbe vector and i40e vector do not support vlan stripping,=20 As I remember, they do. Konstantin >so from what I see there is nothing to do: > - The new flag PKT_RX_VLAN_STRIPPED is never returned > - We keep the old behavior for PKT_RX_VLAN_PKT. >=20 > Thanks, > Olivier