From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C4D064AC7 for ; Mon, 13 Jun 2016 14:39:36 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 13 Jun 2016 05:39:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="718248729" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jun 2016 05:39:34 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by IRSMSX102.ger.corp.intel.com ([169.254.2.10]) with mapi id 14.03.0248.002; Mon, 13 Jun 2016 13:39:33 +0100 From: "Ananyev, Konstantin" To: Olivier Matz , "dev@dpdk.org" CC: "johndale@cisco.com" , "Zhang, Helin" , "arnon@qwilt.com" , "rolette@infinite.io" , "Chen, Jing D" , "Wu, Jingjing" Thread-Topic: [PATCH] mbuf: remove unused Rx error flags Thread-Index: AQHRtMjosx32uuFNWky5ZXW6HzLh3Z/ndkrQ Date: Mon, 13 Jun 2016 12:39:33 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B6FD97@irsmsx105.ger.corp.intel.com> References: <57344C06.1030007@6wind.com> <1463990171-10295-1-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1463990171-10295-1-git-send-email-olivier.matz@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mbuf: remove unused Rx error flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2016 12:39:37 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Monday, May 23, 2016 8:56 AM > To: dev@dpdk.org > Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon@qwilt.co= m; rolette@infinite.io; Chen, Jing D; Wu, Jingjing > Subject: [PATCH] mbuf: remove unused Rx error flags >=20 > Following the discussions from: > http://dpdk.org/ml/archives/dev/2015-July/021721.html > http://dpdk.org/ml/archives/dev/2016-April/038143.html >=20 > The value of these flags is 0, making them useless. Today, no example > application checks them on Rx, and only few drivers sets them and > silently give wrong packets to the application, which should not happen. >=20 > This patch removes the unused flags from rte_mbuf and their use in the > drivers. The i40e and fm10k are kept as they are today and should be > fixed to drop bad packets. The enic driver is managed by its maintainer > in another patch. >=20 > Fixes: c22265f6 ("mbuf: add new packet flags for i40e") > Signed-off-by: Olivier Matz > --- Acked-by: Konstantin Ananyev