From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id C9DA64CE6
 for <dev@dpdk.org>; Mon, 13 Jun 2016 14:42:20 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP; 13 Jun 2016 05:42:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="1000845035"
Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3])
 by fmsmga002.fm.intel.com with ESMTP; 13 Jun 2016 05:42:19 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by
 IRSMSX108.ger.corp.intel.com ([169.254.11.183]) with mapi id 14.03.0248.002;
 Mon, 13 Jun 2016 13:42:18 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "johndale@cisco.com" <johndale@cisco.com>, "Zhang, Helin"
 <helin.zhang@intel.com>, "arnon@qwilt.com" <arnon@qwilt.com>,
 "rolette@infinite.io" <rolette@infinite.io>, "Chen, Jing D"
 <jing.d.chen@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
Thread-Topic: [PATCH] mbuf: remove unused Rx error flags
Thread-Index: AQHRtMjosx32uuFNWky5ZXW6HzLh3Z/ndkrQgAABnjA=
Date: Mon, 13 Jun 2016 12:42:17 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836B6FDB0@irsmsx105.ger.corp.intel.com>
References: <57344C06.1030007@6wind.com>
 <1463990171-10295-1-git-send-email-olivier.matz@6wind.com> 
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] mbuf: remove unused Rx error flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2016 12:42:21 -0000


Hi Olivier,

> > -----Original Message-----
> > From: Olivier Matz [mailto:olivier.matz@6wind.com]
> > Sent: Monday, May 23, 2016 8:56 AM
> > To: dev@dpdk.org
> > Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon@qwilt.=
com; rolette@infinite.io; Chen, Jing D; Wu, Jingjing
> > Subject: [PATCH] mbuf: remove unused Rx error flags
> >
> > Following the discussions from:
> > http://dpdk.org/ml/archives/dev/2015-July/021721.html
> > http://dpdk.org/ml/archives/dev/2016-April/038143.html
> >
> > The value of these flags is 0, making them useless. Today, no example
> > application checks them on Rx, and only few drivers sets them and
> > silently give wrong packets to the application, which should not happen=
.
> >
> > This patch removes the unused flags from rte_mbuf and their use in the
> > drivers. The i40e and fm10k are kept as they are today and should be
> > fixed to drop bad packets. The enic driver is managed by its maintainer
> > in another patch.
> >
> > Fixes: c22265f6 ("mbuf: add new packet flags for i40e")
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
>=20
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>


Just a note, I think you'll need to rebase your patch with latest code.
enic PMD fails to compile.
Please feel free to keep my ack on it.
Konstantin