From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1E7B4C5F0 for ; Wed, 15 Jun 2016 14:33:26 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 15 Jun 2016 05:33:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,475,1459839600"; d="scan'208";a="998113469" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga002.jf.intel.com with ESMTP; 15 Jun 2016 05:33:24 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by IRSMSX106.ger.corp.intel.com ([169.254.8.145]) with mapi id 14.03.0248.002; Wed, 15 Jun 2016 13:33:23 +0100 From: "Ananyev, Konstantin" To: Olivier Matz , "dev@dpdk.org" CC: "johndale@cisco.com" , "Zhang, Helin" , "adrien.mazarguil@6wind.com" , "rahul.lakkireddy@chelsio.com" , "alejandro.lucero@netronome.com" , "sony.chacko@qlogic.com" Thread-Topic: [PATCH v3] mbuf: new flag when Vlan is stripped Thread-Index: AQHRxvv6+ftQ4FPCr0KE2dCyrEP7CJ/qdegg Date: Wed, 15 Jun 2016 12:33:23 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B71793@irsmsx105.ger.corp.intel.com> References: <1464359593-3534-1-git-send-email-olivier.matz@6wind.com> <1465991287-28262-1-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1465991287-28262-1-git-send-email-olivier.matz@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] mbuf: new flag when Vlan is stripped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 12:33:27 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Wednesday, June 15, 2016 12:48 PM > To: dev@dpdk.org > Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; adrien.mazargu= il@6wind.com; rahul.lakkireddy@chelsio.com; > alejandro.lucero@netronome.com; sony.chacko@qlogic.com > Subject: [PATCH v3] mbuf: new flag when Vlan is stripped >=20 > The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in > PMDs not advertising the same flags in similar conditions. >=20 > Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED > and PKT_RX_QINQ_STRIPPED that are better defined: >=20 > PKT_RX_VLAN_STRIPPED: a vlan has been stripped by the hardware and its > tci is saved in mbuf->vlan_tci. This can only happen if vlan stripping > is enabled in the RX configuration of the PMD. >=20 > For now, the old flag PKT_RX_VLAN_PKT is kept but marked as deprecated. > It should be removed from applications and PMDs in a future revision. >=20 > This patch also updates the drivers. For PKT_RX_VLAN_PKT: >=20 > - e1000, enic, i40e, mlx5, nfp, vmxnet3: done, PKT_RX_VLAN_PKT already > had the same meaning than PKT_RX_VLAN_STRIPPED, minor update is > required. > - fm10k: done, PKT_RX_VLAN_PKT already had the same meaning than > PKT_RX_VLAN_STRIPPED, and vlan stripping is always enabled on fm10k. > - ixgbe: modification done (vector and normal), the old flag was set > when a vlan was recognized, even if vlan stripping was disabled. > - the other drivers do not support vlan stripping. >=20 > For PKT_RX_QINQ_PKT, it was only supported on i40e, and the behavior was > already correct, so we can reuse the same bit value for > PKT_RX_QINQ_STRIPPED. >=20 > [1] http://dpdk.org/ml/archives/dev/2016-April/037837.html, >=20 > Signed-off-by: Olivier Matz > --- Acked-by: Konstantin Ananyev