From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 837191F5 for ; Mon, 20 Jun 2016 15:58:07 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 20 Jun 2016 06:58:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,498,1459839600"; d="scan'208";a="831712938" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 20 Jun 2016 06:58:05 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0248.002; Mon, 20 Jun 2016 14:58:04 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon , Jerin Jacob CC: "dev@dpdk.org" , "Hunt, David" , "olivier.matz@6wind.com" , "viktorin@rehivetech.com" , "shreyansh.jain@nxp.com" Thread-Topic: [dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler Thread-Index: AQHRyvdYXP0q+74klk2PkAxJ6pyNBJ/yT8oAgAARI9A= Date: Mon, 20 Jun 2016 13:58:04 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B73750@irsmsx105.ger.corp.intel.com> References: <1463669335-30378-1-git-send-email-david.hunt@intel.com> <1466428091-115821-2-git-send-email-david.hunt@intel.com> <20160620132506.GA3301@localhost.localdomain> <3416153.NDoMD8TpjF@xps13> In-Reply-To: <3416153.NDoMD8TpjF@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 13:58:07 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, June 20, 2016 2:54 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Hunt, David; olivier.matz@6wind.com; viktorin@rehivetec= h.com; shreyansh.jain@nxp.com > Subject: Re: [dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool = handler >=20 > 2016-06-20 18:55, Jerin Jacob: > > On Mon, Jun 20, 2016 at 02:08:10PM +0100, David Hunt wrote: > > > This is a mempool handler that is useful for pipelining apps, where > > > the mempool cache doesn't really work - example, where we have one > > > core doing rx (and alloc), and another core doing Tx (and return). In > > > such a case, the mempool ring simply cycles through all the mbufs, > > > resulting in a LLC miss on every mbuf allocated when the number of > > > mbufs is large. A stack recycles buffers more effectively in this > > > case. > > > > > > Signed-off-by: David Hunt > > > --- > > > lib/librte_mempool/Makefile | 1 + > > > lib/librte_mempool/rte_mempool_stack.c | 145 +++++++++++++++++++++++= ++++++++++ > > > > How about moving new mempool handlers to drivers/mempool? (or similar). > > In future, adding HW specific handlers in lib/librte_mempool/ may be ba= d idea. >=20 > You're probably right. > However we need to check and understand what a HW mempool handler will be= . > I imagine the first of them will have to move handlers in drivers/ Does it mean it we'll have to move mbuf into drivers too? Again other libs do use mempool too. Why not just lib/librte_mempool/arch/ ? Konstantin > Jerin, are you volunteer?