From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1B9254AAD for ; Tue, 26 Jul 2016 14:12:00 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 26 Jul 2016 05:11:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,424,1464678000"; d="scan'208";a="1014060959" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga001.fm.intel.com with ESMTP; 26 Jul 2016 05:11:47 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 26 Jul 2016 13:11:46 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by IRSMSX156.ger.corp.intel.com ([169.254.3.57]) with mapi id 14.03.0248.002; Tue, 26 Jul 2016 13:11:46 +0100 From: "Ananyev, Konstantin" To: "dumitru.ceara@gmail.com" , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Helin" , "Wu, Jingjing" Thread-Topic: [PATCH] net/i40e: fix setting RSS in i40e_recv_scattered_pkts Thread-Index: AQHR5ysQvBh+uBrIME6VyLlKBzVtxKAqnnyQ Date: Tue, 26 Jul 2016 12:11:44 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B820EF@irsmsx105.ger.corp.intel.com> References: <2601191342CEEE43887BDE71AB97725836B82044@irsmsx105.ger.corp.intel.com> <1469529969-31925-1-git-send-email-dumitru.ceara@gmail.com> In-Reply-To: <1469529969-31925-1-git-send-email-dumitru.ceara@gmail.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix setting RSS in i40e_recv_scattered_pkts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2016 12:12:01 -0000 > -----Original Message----- > From: dumitru.ceara@gmail.com [mailto:dumitru.ceara@gmail.com] > Sent: Tuesday, July 26, 2016 11:46 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Helin ; Wu, Jingjing ; Ananyev, Konstantin > ; Dumitru Ceara > Subject: [PATCH] net/i40e: fix setting RSS in i40e_recv_scattered_pkts >=20 > From: Dumitru Ceara >=20 > The driver is incorrectly setting the RSS field in the last mbuf in the p= acket chain instead of the first. Moreover, the last mbuf might have > already been freed if it only contained the Ethernet CRC. >=20 > Also, fix the call to i40e_rxd_build_fdir to store the fdir flags in the = first mbuf of the chain instead of the last. >=20 > Signed-off-by: Dumitru Ceara > --- > drivers/net/i40e/i40e_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index d3cfb98..554d167 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -1436,10 +1436,10 @@ i40e_recv_scattered_pkts(void *rx_queue, > i40e_rxd_pkt_type_mapping((uint8_t)((qword1 & > I40E_RXD_QW1_PTYPE_MASK) >> I40E_RXD_QW1_PTYPE_SHIFT)); > if (pkt_flags & PKT_RX_RSS_HASH) > - rxm->hash.rss =3D > + first_seg->hash.rss =3D > rte_le_to_cpu_32(rxd.wb.qword0.hi_dword.rss); > if (pkt_flags & PKT_RX_FDIR) > - pkt_flags |=3D i40e_rxd_build_fdir(&rxd, rxm); > + pkt_flags |=3D i40e_rxd_build_fdir(&rxd, first_seg); >=20 > #ifdef RTE_LIBRTE_IEEE1588 > pkt_flags |=3D i40e_get_iee15888_flags(first_seg, qword1); > -- Acked-by: Konstantin Ananyev > 1.9.1