DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce renaming of ethdev library
@ 2016-07-26 16:22 Thomas Monjalon
  2016-07-27 16:33 ` [dpdk-dev] " Jan Viktorin
       [not found] ` <B27915DBBA3421428155699D51E4CFE2025A902D@IRSMSX103.ger.corp.intel.com>
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-07-26 16:22 UTC (permalink / raw)
  To: dev

The right name of ethdev should be dpdk_netdev. However:
1/ We are using rte_ prefix in the code and library names.
2/ The API uses rte_ethdev
That's why 16.11 will just have the rte_ prefix prepended to
the library filename as every other libraries.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index f502f86..7a55037 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -11,6 +11,9 @@ Deprecation Notices
 * The log history is deprecated.
   It is voided in 16.07 and will be removed in release 16.11.
 
+* The ethdev library file will be renamed from libethdev.* to librte_ethdev.*
+  in release 16.11 in order to have a more consistent namespace.
+
 * The ethdev hotplug API is going to be moved to EAL with a notification
   mechanism added to crypto and ethdev libraries so that hotplug is now
   available to both of them. This API will be stripped of the device arguments
-- 
2.7.0

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] doc: announce renaming of ethdev library
  2016-07-26 16:22 [dpdk-dev] [PATCH] doc: announce renaming of ethdev library Thomas Monjalon
@ 2016-07-27 16:33 ` Jan Viktorin
  2016-07-28  9:29   ` Christian Ehrhardt
       [not found] ` <B27915DBBA3421428155699D51E4CFE2025A902D@IRSMSX103.ger.corp.intel.com>
  1 sibling, 1 reply; 6+ messages in thread
From: Jan Viktorin @ 2016-07-27 16:33 UTC (permalink / raw)
  To: dev; +Cc: Thomas Monjalon

On Tue, 26 Jul 2016 18:22:21 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> The right name of ethdev should be dpdk_netdev. However:
> 1/ We are using rte_ prefix in the code and library names.
> 2/ The API uses rte_ethdev
> That's why 16.11 will just have the rte_ prefix prepended to
> the library filename as every other libraries.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
Acked-by: Jan Viktorin <viktorin@rehivetech.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] doc: announce renaming of ethdev library
  2016-07-27 16:33 ` [dpdk-dev] " Jan Viktorin
@ 2016-07-28  9:29   ` Christian Ehrhardt
  2016-07-28  9:52     ` Thomas Monjalon
  2016-07-28 17:37     ` Thomas Monjalon
  0 siblings, 2 replies; 6+ messages in thread
From: Christian Ehrhardt @ 2016-07-28  9:29 UTC (permalink / raw)
  To: Jan Viktorin; +Cc: dev, Thomas Monjalon

Hi Thomas,
just my two cents as Ubuntu DPDK maintainer (and part of the Debian Team
that does the same).
(Yeah I really could reuse it three times :-) )

It will be a bit of effort to adapt, but should be no rocket-science.
I like that eventually the namespace will be cleaner.

Just curious, do we already know by looking ahead if ethdev will get an ABI
bump anyway?
So will the transition be:
a) libethdev4 -> librte_ethdev5
b)libethdev4 -> librte_ethdev4
If it is b) would/should one provide a compat symlink then in your Opinion?

Anyway, for now I think it is fair to say:
Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

On Wed, Jul 27, 2016 at 6:33 PM, Jan Viktorin <viktorin@rehivetech.com>
wrote:

> On Tue, 26 Jul 2016 18:22:21 +0200
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> > The right name of ethdev should be dpdk_netdev. However:
> > 1/ We are using rte_ prefix in the code and library names.
> > 2/ The API uses rte_ethdev
> > That's why 16.11 will just have the rte_ prefix prepended to
> > the library filename as every other libraries.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> >
> Acked-by: Jan Viktorin <viktorin@rehivetech.com>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] doc: announce renaming of ethdev library
  2016-07-28  9:29   ` Christian Ehrhardt
@ 2016-07-28  9:52     ` Thomas Monjalon
  2016-07-28 17:37     ` Thomas Monjalon
  1 sibling, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-07-28  9:52 UTC (permalink / raw)
  To: Christian Ehrhardt; +Cc: Jan Viktorin, dev

2016-07-28 11:29, Christian Ehrhardt:
> Just curious, do we already know by looking ahead if ethdev will get an ABI
> bump anyway?
> So will the transition be:
> a) libethdev4 -> librte_ethdev5
> b)libethdev4 -> librte_ethdev4
> If it is b) would/should one provide a compat symlink then in your Opinion?

Good point.
We'll make a symlink if the version stay the same.
Maybe it will be bumped because of a rework of the hotplug API.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce renaming of ethdev library
       [not found]     ` <B27915DBBA3421428155699D51E4CFE2025A9104@IRSMSX103.ger.corp.intel.com>
@ 2016-07-28 11:29       ` Ananyev, Konstantin
  0 siblings, 0 replies; 6+ messages in thread
From: Ananyev, Konstantin @ 2016-07-28 11:29 UTC (permalink / raw)
  To: dev; +Cc: Thomas Monjalon (thomas.monjalon@6wind.com)



>
> The right name of ethdev should be dpdk_netdev. However:
> 1/ We are using rte_ prefix in the code and library names.
> 2/ The API uses rte_ethdev
 > That's why 16.11 will just have the rte_ prefix prepended to the
> library filename as every other libraries.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
 > ---
 >  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index f502f86..7a55037 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -11,6 +11,9 @@ Deprecation Notices
>  * The log history is deprecated.
>    It is voided in 16.07 and will be removed in release 16.11.
>
> +* The ethdev library file will be renamed from libethdev.* to
> +librte_ethdev.*
> +  in release 16.11 in order to have a more consistent namespace.
> +
>  * The ethdev hotplug API is going to be moved to EAL with a
> notification
>    mechanism added to crypto and ethdev libraries so that hotplug
> is
> now
 >    available to both of them. This API will be stripped of the
> device arguments
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.7.0

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] doc: announce renaming of ethdev library
  2016-07-28  9:29   ` Christian Ehrhardt
  2016-07-28  9:52     ` Thomas Monjalon
@ 2016-07-28 17:37     ` Thomas Monjalon
  1 sibling, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-07-28 17:37 UTC (permalink / raw)
  To: dev

> > > The right name of ethdev should be dpdk_netdev. However:
> > > 1/ We are using rte_ prefix in the code and library names.
> > > 2/ The API uses rte_ethdev
> > > That's why 16.11 will just have the rte_ prefix prepended to
> > > the library filename as every other libraries.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > >
> > Acked-by: Jan Viktorin <viktorin@rehivetech.com>
Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-07-28 17:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-26 16:22 [dpdk-dev] [PATCH] doc: announce renaming of ethdev library Thomas Monjalon
2016-07-27 16:33 ` [dpdk-dev] " Jan Viktorin
2016-07-28  9:29   ` Christian Ehrhardt
2016-07-28  9:52     ` Thomas Monjalon
2016-07-28 17:37     ` Thomas Monjalon
     [not found] ` <B27915DBBA3421428155699D51E4CFE2025A902D@IRSMSX103.ger.corp.intel.com>
     [not found]   ` <2601191342CEEE43887BDE71AB97725836B8AAA2@irsmsx105.ger.corp.intel.com>
     [not found]     ` <B27915DBBA3421428155699D51E4CFE2025A9104@IRSMSX103.ger.corp.intel.com>
2016-07-28 11:29       ` [dpdk-dev] [PATCH] " Ananyev, Konstantin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).