From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 85034FB68 for ; Tue, 20 Dec 2016 13:17:14 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 20 Dec 2016 04:17:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,378,1477983600"; d="scan'208";a="45139969" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga006.fm.intel.com with ESMTP; 20 Dec 2016 04:17:12 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.212]) by IRSMSX106.ger.corp.intel.com ([169.254.8.66]) with mapi id 14.03.0248.002; Tue, 20 Dec 2016 12:17:11 +0000 From: "Ananyev, Konstantin" To: Adrien Mazarguil , Billy McFall CC: "thomas.monjalon@6wind.com" , "Lu, Wenzhuo" , "dev@dpdk.org" , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 1/3] ethdev: New API to free consumed buffers in TX ring Thread-Index: AQHSWrQteKYKpLnjn0O52Ia9MN2/U6EQvl8w Date: Tue, 20 Dec 2016 12:17:10 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F0F2D8A@irsmsx105.ger.corp.intel.com> References: <20161216124851.2640-1-bmcfall@redhat.com> <20161216124851.2640-2-bmcfall@redhat.com> <20161220112746.GT10340@6wind.com> In-Reply-To: <20161220112746.GT10340@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: New API to free consumed buffers in TX ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 12:17:15 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Tuesday, December 20, 2016 11:28 AM > To: Billy McFall > Cc: thomas.monjalon@6wind.com; Lu, Wenzhuo ; dev@dp= dk.org; Stephen Hemminger > > Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: New API to free consumed buff= ers in TX ring >=20 > Hi Billy, >=20 > On Fri, Dec 16, 2016 at 07:48:49AM -0500, Billy McFall wrote: > > Add a new API to force free consumed buffers on TX ring. API will retur= n > > the number of packets freed (0-n) or error code if feature not supporte= d > > (-ENOTSUP) or input invalid (-ENODEV). > > > > Because rte_eth_tx_buffer() may be used, and mbufs may still be held > > in local buffer, the API also accepts *buffer and *sent. Before > > attempting to free, rte_eth_tx_buffer_flush() is called to make sure > > all mbufs are sent to Tx ring. rte_eth_tx_buffer_flush() is called even > > if threshold is not met. > > > > Signed-off-by: Billy McFall > > --- > > lib/librte_ether/rte_ethdev.h | 56 +++++++++++++++++++++++++++++++++++= ++++++++ > > 1 file changed, 56 insertions(+) > > > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethde= v.h > > index 9678179..e3f2be4 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -1150,6 +1150,9 @@ typedef uint32_t (*eth_rx_queue_count_t)(struct r= te_eth_dev *dev, > > typedef int (*eth_rx_descriptor_done_t)(void *rxq, uint16_t offset); > > /**< @internal Check DD bit of specific RX descriptor */ > > > > +typedef int (*eth_tx_done_cleanup_t)(void *txq, uint32_t free_cnt); > > +/**< @internal Force mbufs to be from TX ring. */ > > + > > typedef void (*eth_rxq_info_get_t)(struct rte_eth_dev *dev, > > uint16_t rx_queue_id, struct rte_eth_rxq_info *qinfo); > > > > @@ -1467,6 +1470,7 @@ struct eth_dev_ops { > > eth_rx_disable_intr_t rx_queue_intr_disable; > > eth_tx_queue_setup_t tx_queue_setup;/**< Set up device TX queue= .*/ > > eth_queue_release_t tx_queue_release;/**< Release TX queue.*/ > > + eth_tx_done_cleanup_t tx_done_cleanup;/**< Free tx ring mbufs */ > > eth_dev_led_on_t dev_led_on; /**< Turn on LED. */ > > eth_dev_led_off_t dev_led_off; /**< Turn off LED. */ > > flow_ctrl_get_t flow_ctrl_get; /**< Get flow control. */ > > @@ -2943,6 +2947,58 @@ rte_eth_tx_buffer(uint8_t port_id, uint16_t queu= e_id, > > } > > > > /** > > + * Request the driver to free mbufs currently cached by the driver. Th= e > > + * driver will only free the mbuf if it is no longer in use. > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param queue_id > > + * The index of the transmit queue through which output packets must= be > > + * sent. > > + * The value must be in the range [0, nb_tx_queue - 1] previously su= pplied > > + * to rte_eth_dev_configure(). > > + * @param free_cnt > > + * Maximum number of packets to free. Use 0 to indicate all possible= packets > > + * should be freed. Note that a packet may be using multiple mbufs. > > + * @param buffer > > + * Buffer used to collect packets to be sent. If provided, the buffe= r will > > + * be flushed, even if the current length is less than buffer->size.= Pass NULL > > + * if buffer has already been flushed. > > + * @param sent > > + * Pointer to return number of packets sent if buffer has packets to= be sent. > > + * If *buffer is supplied, *sent must also be supplied. > > + * @return > > + * Failure: < 0 > > + * -ENODEV: Invalid interface > > + * -ENOTSUP: Driver does not support function > > + * Success: >=3D 0 > > + * 0-n: Number of packets freed. More packets may still remain in = ring that > > + * are in use. > > + */ > > + > > +static inline int > > +rte_eth_tx_done_cleanup(uint8_t port_id, uint16_t queue_id, uint32_t = free_cnt, > > + struct rte_eth_dev_tx_buffer *buffer, uint16_t *sent) > > +{ > > + struct rte_eth_dev *dev =3D &rte_eth_devices[port_id]; > > + > > + /* Validate Input Data. Bail if not valid or not supported. */ > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_done_cleanup, -ENOTSUP); > > + > > + /* > > + * If transmit buffer is provided and there are still packets to be > > + * sent, then send them before attempting to free pending mbufs. > > + */ > > + if (buffer && sent) > > + *sent =3D rte_eth_tx_buffer_flush(port_id, queue_id, buffer); > > + > > + /* Call driver to free pending mbufs. */ > > + return (*dev->dev_ops->tx_done_cleanup)(dev->data->tx_queues[queue_id= ], > > + free_cnt); > > +} > > + > > +/** > > * Configure a callback for buffered packets which cannot be sent > > * > > * Register a specific callback to be called when an attempt is made t= o send >=20 > Just a thought to follow-up on Stephen's comment to further simplify this > API, how about not adding any new eth_dev_ops but instead defining what > should happen during an empty TX burst call (tx_burst() with 0 packets). >=20 > Several PMDs already have a check for this scenario and start by cleaning= up > completed packets anyway, they effectively partially implement this > definition for free already. Many PMDs start by cleaning up only when number of free entries drop below some point. Also in that case the author would have to modify (and test) all existing T= X routinies. So I think a separate API call seems more plausible. Though I am agree with previous comment from Stephen that last two paramete= rs are redundant and would just overcomplicate things. tin >=20 > The main difference with this API would be that you wouldn't know how man= y > mbufs were freed and wouldn't collect them into an array. However most > applications have one mbuf pool and/or know where they come from, so they > can just query the pool or attempt to re-allocate from it after doing emp= ty > bursts in case of starvation. >=20 > [1] http://dpdk.org/ml/archives/dev/2016-December/052469.html >=20 > -- > Adrien Mazarguil > 6WIND