From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5BEFA10E15 for ; Fri, 23 Dec 2016 10:36:36 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 23 Dec 2016 01:36:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,392,1477983600"; d="scan'208";a="45763039" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga005.jf.intel.com with ESMTP; 23 Dec 2016 01:36:34 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by IRSMSX106.ger.corp.intel.com ([169.254.8.197]) with mapi id 14.03.0248.002; Fri, 23 Dec 2016 09:36:33 +0000 From: "Ananyev, Konstantin" To: Michal Miroslaw CC: "dev@dpdk.org" Thread-Topic: [PATCH] acl: remove invalid test Thread-Index: AQHSVi7iuYM9V+6wvkipwF3p7exsIqEPpGmAgAUsXgCAAIJP8A== Date: Fri, 23 Dec 2016 09:36:33 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F0F876A@irsmsx105.ger.corp.intel.com> References: <2601191342CEEE43887BDE71AB9772583F0F2997@irsmsx105.ger.corp.intel.com> <20161223014752.wicbgkvlotllsfc6@rere.qmqm.pl> In-Reply-To: <20161223014752.wicbgkvlotllsfc6@rere.qmqm.pl> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] acl: remove invalid test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 09:36:36 -0000 > -----Original Message----- > From: Michal Miroslaw [mailto:mirq-linux@rere.qmqm.pl] > Sent: Friday, December 23, 2016 1:48 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [PATCH] acl: remove invalid test >=20 > On Mon, Dec 19, 2016 at 06:48:52PM +0000, Ananyev, Konstantin wrote: > > Hi Michal, > > > > > -----Original Message----- > > > From: Micha=B3 Miros=B3aw [mailto:mirq-linux@rere.qmqm.pl] > > > Sent: Wednesday, December 14, 2016 5:24 PM > > > To: dev@dpdk.org > > > Cc: Ananyev, Konstantin > > > Subject: [PATCH] acl: remove invalid test > > > > > > rte_acl_add_rules() has no way of checking rule size. > > > > > > This was hidden because the test effectively checked that > > > adding a rule with userdata =3D=3D 0 failed. > > I suppose that changes have to be inside: > > [PATCH v2] acl: allow zero verdict. >=20 > The 'allow zero verdict' patch depends on this one if we are to not have > a breaking tests inbetween.=20 Exactly, that's why I think they either has to be in one series of patches, with this one coming first and ' PATCH v2] acl: allow zero verdict' as the = second one, or just merge them into one. Konstantin >Otherwise, it is an independent change. >=20 > I guess I can merge them, though, if you prefer it that way. >=20 > Best Regards, > Micha=B3=A0Miros=B3aw