From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 600392A6C for ; Wed, 4 Jan 2017 15:21:11 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP; 04 Jan 2017 06:21:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,459,1477983600"; d="scan'208";a="49995584" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga006.fm.intel.com with ESMTP; 04 Jan 2017 06:21:09 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by IRSMSX107.ger.corp.intel.com ([169.254.10.3]) with mapi id 14.03.0248.002; Wed, 4 Jan 2017 14:21:09 +0000 From: "Ananyev, Konstantin" To: "Bie, Tiwei" , "dev@dpdk.org" CC: "adrien.mazarguil@6wind.com" , "Lu, Wenzhuo" , "Mcnamara, John" , "olivier.matz@6wind.com" , "thomas.monjalon@6wind.com" , "Zhang, Helin" , "Dai, Wei" , "Wang, Xiao W" Thread-Topic: [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API Thread-Index: AQHSZlwkSqPRhUiAJ0W/zN9yefcZuKEoXWKA Date: Wed, 4 Jan 2017 14:21:08 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F0FEE0C@irsmsx105.ger.corp.intel.com> References: <1482939691-34855-1-git-send-email-tiwei.bie@intel.com> <1483514502-32841-1-git-send-email-tiwei.bie@intel.com> <1483514502-32841-4-git-send-email-tiwei.bie@intel.com> In-Reply-To: <1483514502-32841-4-git-send-email-tiwei.bie@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 14:21:13 -0000 Hi Twei, > -----Original Message----- > From: Bie, Tiwei > Sent: Wednesday, January 4, 2017 7:22 AM > To: dev@dpdk.org > Cc: adrien.mazarguil@6wind.com; Lu, Wenzhuo ; Mcnam= ara, John ; > olivier.matz@6wind.com; thomas.monjalon@6wind.com; Ananyev, Konstantin ; Zhang, Helin > ; Dai, Wei ; Wang, Xiao W > Subject: [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific= API >=20 > Reserve a Tx capability flag and a Rx capability flag, that can be > used by PMD to define its own capability flags when implementing the > PMD-specific API. >=20 > Suggested-by: Adrien Mazarguil > Signed-off-by: Tiwei Bie > Acked-by: Wenzhuo Lu > --- > lib/librte_ether/rte_ethdev.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.= h > index d465825..8800b39 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -857,6 +857,7 @@ struct rte_eth_conf { > #define DEV_RX_OFFLOAD_TCP_LRO 0x00000010 > #define DEV_RX_OFFLOAD_QINQ_STRIP 0x00000020 > #define DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM 0x00000040 > +#define DEV_RX_OFFLOAD_RESERVED_0 0x00000080 /**< Used for PMD-specific= API. */ >=20 > /** > * TX offload capabilities of a device. > @@ -874,6 +875,7 @@ struct rte_eth_conf { > #define DEV_TX_OFFLOAD_GRE_TNL_TSO 0x00000400 /**< Used for tunn= eling packet. */ > #define DEV_TX_OFFLOAD_IPIP_TNL_TSO 0x00000800 /**< Used for tunn= eling packet. */ > #define DEV_TX_OFFLOAD_GENEVE_TNL_TSO 0x00001000 /**< Used for tunn= eling packet. */ > +#define DEV_TX_OFFLOAD_RESERVED_0 0x00002000 /**< Used for PMD-specific= API. */ >=20 > /** > * Ethernet device information > -- > 2.7.4 I am not sure how that supposed to work and how user should know that DEV_R= X_OFFLOAD_RESERVED_0 =20 is actually a MACSEC for ixgbe? Another question what to do if you would like to create a bonded device ove= r two devices with different NIC types? As I understand you can end up in situation when DEV_RX_OFFLOAD_RESERVED_0= would mean different capabilities. Why not to have this MACSEC capability and ol_flag value as generic ones, a= s you have them in previous versions of your patch? Konstantin