From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id DAC90108D
 for <dev@dpdk.org>; Thu, 26 Jan 2017 15:58:23 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP; 26 Jan 2017 06:58:22 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,289,1477983600"; d="scan'208";a="1118155284"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by fmsmga002.fm.intel.com with ESMTP; 26 Jan 2017 06:58:22 -0800
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.160]) with mapi id 14.03.0248.002;
 Thu, 26 Jan 2017 14:58:08 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Wu, Jingjing" <jingjing.wu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags
Thread-Index: AQHSdjf/GdSv8Vm7LEyQbSCKSFxHsqFK25Yg
Date: Thu, 26 Jan 2017 14:58:08 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772583F10D0CB@irsmsx105.ger.corp.intel.com>
References: <1485258454-86107-1-git-send-email-jingjing.wu@intel.com>
In-Reply-To: <1485258454-86107-1-git-send-email-jingjing.wu@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jan 2017 14:58:24 -0000

Hi Jingjng,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jingjing Wu
> Sent: Tuesday, January 24, 2017 11:48 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags
>=20
> Some Tx offload flags are missed in Bitmask of all supported packet
> Tx offload features flags.
> This patch fixes it.

Not sure what it exactly fixes?
As I remember these flags don't specify any TX offload for HW to perform,
But just provide information to the TX function.
Again, why only i40e code is modified?
As I remember we have the same code in other PMDs too.
Konstantin

>=20
> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
>  lib/librte_mbuf/rte_mbuf.h | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index bfce9f4..e57a4d2 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -295,8 +295,12 @@ extern "C" {
>   */
>  #define PKT_TX_OFFLOAD_MASK (    \
>  		PKT_TX_IP_CKSUM |        \
> +		PKT_TX_IPV4 |            \
> +		PKT_TX_IPV6 |            \
>  		PKT_TX_L4_MASK |         \
>  		PKT_TX_OUTER_IP_CKSUM |  \
> +		PKT_TX_OUTER_IPV4 |      \
> +		PKT_TX_OUTER_IPV6 |      \
>  		PKT_TX_TCP_SEG |         \
>  		PKT_TX_QINQ_PKT |        \
>  		PKT_TX_VLAN_PKT |        \
> --
> 2.4.11