From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C53AF2BCD for ; Fri, 3 Feb 2017 10:49:56 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 03 Feb 2017 01:49:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,328,1477983600"; d="scan'208";a="39209160" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga002.jf.intel.com with ESMTP; 03 Feb 2017 01:49:54 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by IRSMSX108.ger.corp.intel.com ([169.254.11.173]) with mapi id 14.03.0248.002; Fri, 3 Feb 2017 09:49:53 +0000 From: "Ananyev, Konstantin" To: "Iremonger, Bernard" , "Yigit, Ferruh" , "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get Thread-Index: AQHSdrRVRl/bTuVA+02KkpIDzfQM9KFUYbeggAAVWYCAAAcVkIACkjkAgAAFo+A= Date: Fri, 3 Feb 2017 09:49:52 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F110909@irsmsx105.ger.corp.intel.com> References: <1485311962-62335-1-git-send-email-wenzhuo.lu@intel.com> <2601191342CEEE43887BDE71AB9772583F10FFA1@irsmsx105.ger.corp.intel.com> <410cf75d-0ceb-d372-778f-bfa19392443b@intel.com> <2601191342CEEE43887BDE71AB9772583F110053@irsmsx105.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D25A9D@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C224D25A9D@IRSMSX108.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 09:49:57 -0000 Hi Bernard, > -----Original Message----- > From: Iremonger, Bernard > Sent: Friday, February 3, 2017 9:21 AM > To: Ananyev, Konstantin ; Yigit, Ferruh ; Lu, Wenzhuo ; > dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get >=20 > Hi Konstantin, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, > > Konstantin > > Sent: Wednesday, February 1, 2017 6:10 PM > > To: Yigit, Ferruh ; Lu, Wenzhuo > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_ge= t > > > > > > > > > -----Original Message----- > > > From: Yigit, Ferruh > > > Sent: Wednesday, February 1, 2017 5:40 PM > > > To: Ananyev, Konstantin ; Lu, Wenzhuo > > > ; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up > > > rte_eth_dev_info_get > > > > > > On 2/1/2017 4:24 PM, Ananyev, Konstantin wrote: > > > > Hi Wenzhuo, > > > > > > > >> -----Original Message----- > > > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > > >> Sent: Wednesday, January 25, 2017 2:39 AM > > > >> To: dev@dpdk.org > > > >> Cc: Lu, Wenzhuo > > > >> Subject: [dpdk-dev] [PATCH] net/ixgbe: clean up > > > >> rte_eth_dev_info_get > > > >> > > > >> It'not appropriate to call rte_eth_dev_info_get in PMD, as > > > >> rte_eth_dev_info_get need to get info from PMD. > > > >> Remove rte_eth_dev_info_get from PMD code and get the info > > > >> directly. > > > >> > > > >> Signed-off-by: Wenzhuo Lu > > > >> --- > > > >> drivers/net/ixgbe/ixgbe_ethdev.c | 144 > > > >> ++++++++++++++++++--------------------- > > > >> 1 file changed, 68 insertions(+), 76 deletions(-) > > > >> > > > >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > > >> b/drivers/net/ixgbe/ixgbe_ethdev.c > > > >> index 64ce55a..f14a68b 100644 > > > >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > > >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > > >> @@ -4401,17 +4401,17 @@ static int > > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > > > >> int rar_entry; > > > >> uint8_t *new_mac =3D (uint8_t *)(mac_addr); > > > >> struct rte_eth_dev *dev; > > > >> - struct rte_eth_dev_info dev_info; > > > >> + struct rte_pci_device *pci_dev; > > > >> > > > >> RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > > > >> > > > >> dev =3D &rte_eth_devices[port]; > > > >> - rte_eth_dev_info_get(port, &dev_info); > > > >> + pci_dev =3D IXGBE_DEV_TO_PCI(dev); > > > >> > > > >> - if (is_ixgbe_pmd(dev_info.driver_name) !=3D 0) > > > >> + if (is_ixgbe_pmd(dev->data->drv_name)) > > > >> return -ENOTSUP; > > > > > > > > I wonder why do we need now that it is really an ixgbe device all o= ver the > > place? > > > > > > This device specific API, so it is missing merits of abstraction > > > layer, application can these APIs with any port_id, API should be pro= tected > > for it. > > > > Ah ok, my bad - didn't realize from the patch that it affects only devi= ce > > specific API :) Would It be too much hassle to move these functions int= o a > > separate file (rte_ixgbe_pmd.c or so)? > > Konstantin > > > > > > > > > Konstantin > > > > > All the device specific API functions are prefixed with rte_pmd_ixgbe That's ok. > so I don't think a separate file is necessary. So far I didn't say it is necessary. Though I think it would be good to group these functions in a separate file to help avoid confusion (as happened to me) and keep ixgbe_ethdev.c smaller= and cleaner. Again would be easier to maintain things in future, when more folks will co= me up with some extensions for it. That's why I am asking: would it be a lot of work to do? It is probably worth doing it now, while we have this API relatively small. Konstantin