From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id EC20E2B88 for ; Tue, 28 Feb 2017 11:36:20 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2017 02:36:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,219,1484035200"; d="scan'208";a="230549747" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga004.fm.intel.com with ESMTP; 28 Feb 2017 02:36:19 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by irsmsx110.ger.corp.intel.com ([169.254.15.101]) with mapi id 14.03.0248.002; Tue, 28 Feb 2017 10:36:18 +0000 From: "Ananyev, Konstantin" To: Ravi Kerur , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd Thread-Index: AQHSeOBkYGy9qvovtEmrUjHmBNy4jqF+aZmQ Date: Tue, 28 Feb 2017 10:36:17 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F11EA2A@irsmsx105.ger.corp.intel.com> References: <1485550795-10771-1-git-send-email-rkerur@gmail.com> In-Reply-To: <1485550795-10771-1-git-send-email-rkerur@gmail.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 10:36:21 -0000 Hi Ravi, >=20 > Thanks to Konstantin and Bruce on first internal review comments. This > patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file > read options to build LPM and EM tables. Thanks for the patch, I think it is really useful one. Can I suggest you re-submit it as non-RFC now, as we are in 17.05 window al= ready? About the patch itself, one question I forgot to ask you before: +++ b/examples/l3fwd/main.c @@ -161,7 +163,9 @@ static struct rte_eth_conf port_conf =3D { .rx_adv_conf =3D { .rss_conf =3D { .rss_key =3D NULL, - .rss_hf =3D ETH_RSS_IP, + .rss_hf =3D ETH_RSS_IP | ETH_RSS_UDP | + ETH_RSS_TCP | ETH_RSS_SCTP, + }, }, Why it is necessary to change RSS hash input values? As another nit - there are few checkpatch warnings, that probably need to be addressed. Apart from that looks good to me. Thanks Konstantin