From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Dai, Wei" <wei.dai@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix check of packet type
Date: Mon, 13 Mar 2017 22:13:18 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772583FACE96D@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A377662@PGSMSX106.gar.corp.intel.com>
> > Hi Wei,
> >
> > >
> > > Hi, Konstantin
> > > I see your point.
> > > I think your method can work.
> > > But I think your method is a bit complex. As you method need to add more
> > codes.
> > > Anyway this is a simple bug.
> > > How do you think now ?
> >
> > I still think it is better for all apps to handle this issue in a uniform way.
> > Again in that case for NICs that do support PTYPE offloads the performance
> > should be unaffected.
> > Konstantin
> >
>
> I have just had a quick look through the l3fwd and didn't find any codes to
> check what ptypes capabilities ae provided by stuff below DPDK PMD & its base driver.
> L3fwd only check an input argument "--parse-ptype" to enable ptype check implemented in
> a Rx callback function.
As an example for lpm:
http://dpdk.org/browse/dpdk/tree/examples/l3fwd/l3fwd_lpm.c#n279
Konstantin
> In this l3fwd rx callback function, it has done the same thing as my code.
> Anyway, I'd like to provide a v2 patch to deal with this issue in a uniform way.
>
> Thanks & Best Regards
> -Wei
next prev parent reply other threads:[~2017-03-13 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 3:28 Wei Dai
2017-03-10 3:36 ` Dai, Wei
2017-03-10 12:21 ` Ananyev, Konstantin
2017-03-13 3:29 ` Dai, Wei
2017-03-13 7:01 ` Ananyev, Konstantin
2017-03-13 7:56 ` Dai, Wei
2017-03-13 22:13 ` Ananyev, Konstantin [this message]
2017-03-14 1:18 ` Dai, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772583FACE96D@IRSMSX109.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).