From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C5DFD37B0 for ; Mon, 4 Sep 2017 12:27:13 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 03:27:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="1214448910" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga002.fm.intel.com with ESMTP; 04 Sep 2017 03:27:11 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 11:27:11 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by irsmsx112.ger.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0319.002; Mon, 4 Sep 2017 11:27:10 +0100 From: "Ananyev, Konstantin" To: "Yang, Zhiyong" , "Richardson, Bruce" CC: "Yao, Lei A" , "dev@dpdk.org" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Wiles, Keith" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024 Thread-Index: AQHTJULyfX0H8ykD00qjS6aVBiYsP6KkSHYAgAADuICAABNwgIAAD6+AgAAV4ZA= Date: Mon, 4 Sep 2017 10:27:10 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772584F244EC0@irsmsx105.ger.corp.intel.com> References: <20170809084203.17562-1-zhiyong.yang@intel.com> <20170904055734.21354-1-zhiyong.yang@intel.com> <20170904055734.21354-4-zhiyong.yang@intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A266703@shsmsx102.ccr.corp.intel.com> <20170904090903.GB17464@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 10:27:14 -0000 Hi Zhiong, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Zhiyong > Sent: Monday, September 4, 2017 11:05 AM > To: Richardson, Bruce > Cc: Yao, Lei A ; dev@dpdk.org; thomas@monjalon.net; = Yigit, Ferruh ; Wiles, Keith > ; stephen@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPOR= TS from 32 to 1024 >=20 > Hi, Bruce: >=20 > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Monday, September 4, 2017 5:09 PM > > To: Yang, Zhiyong > > Cc: Yao, Lei A ; dev@dpdk.org; thomas@monjalon.net= ; > > Yigit, Ferruh ; Wiles, Keith ; > > stephen@networkplumber.org > > Subject: Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend > > RTE_MAX_ETHPORTS from 32 to 1024 > > > > > --- a/config/common_base > > > > > +++ b/config/common_base > > > > > @@ -131,7 +131,7 @@ CONFIG_RTE_LIBRTE_KVARGS=3Dy # > > > > > CONFIG_RTE_LIBRTE_ETHER=3Dy CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=3Dn > > > > > -CONFIG_RTE_MAX_ETHPORTS=3D32 > > > > > +CONFIG_RTE_MAX_ETHPORTS=3D1024 > > > > > CONFIG_RTE_MAX_QUEUES_PER_PORT=3D1024 > > > > > CONFIG_RTE_LIBRTE_IEEE1588=3Dn > > > > > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=3D16 > > > > > -- > > > > > 2.13.3 > > > > Hi, Zhiyong > > > > > > > > I met one issue for changing CONFIG_RTE_MAX_ETHPORTS to 1024. > > > > One process can only open 1024 file as maximum in common linux > > > > distribution, after practice, only 1009 socket file can be used for > > > > vdev device with testpmd sample. > > > > > > Thanks for your info. It seems that 1024 is too large and may bring = some > > potential issues. > > > > > > Thanks > > > Zhiyong > > > > > > > It should be possible to have a dynamically allocated ethdev array, whi= ch would > > allow use to have a default value - which could be e.g. 32 or 64 as now= - while > > also allowing a run-time parameter to increase that to thousands if nee= ded. > > > > /Bruce >=20 > In testpmd, the following function will be called to validate the port_i= d. > So, It is necessary to modify the max port num RTE_MAX_ETHPORTS. There are quite a lot memory allocations (both static an dynamic) inside DP= DK libs and sample apps that use RTE_MAX_ETHPORTS. Increasing RTE_MAX_ETHPORTS would increase DPDK memory requirements quite s= ignificantly. Why do you think it is *necessary* to increase default RTE_MAX_ETHPORTS to = 1024? Konstantin >=20 > I think that RTE_MAX_ETHPORTS and a default value(num of port ) should b= e different values. > Now dpdk limits the max num to RTE_MAX_ETHPORTS =3D 32 by default. > int > rte_eth_dev_is_valid_port(uint16_t port_id) > { > if (port_id >=3D RTE_MAX_ETHPORTS || > (rte_eth_devices[port_id].state !=3D RTE_ETH_DEV_ATTACHED && > rte_eth_devices[port_id].state !=3D RTE_ETH_DEV_DEFERRED)) > return 0; > else > return 1; > } >=20 > Thanks > Zhiyong.