From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CDA9F201 for ; Mon, 4 Sep 2017 15:25:13 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 06:25:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="1010784325" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 04 Sep 2017 06:25:11 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0319.002; Mon, 4 Sep 2017 14:25:10 +0100 From: "Ananyev, Konstantin" To: Shahaf Shuler , "thomas@monjalon.net" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API Thread-Index: AQHTJU1fVpbLAok7P06kzXdRtIICjKKkr2EA Date: Mon, 4 Sep 2017 13:25:10 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772584F24602F@irsmsx105.ger.corp.intel.com> References: <810c1d26724f82f0d9fc9d6684dc4b1c62fd5f62.1504508375.git.shahafs@mellanox.com> In-Reply-To: <810c1d26724f82f0d9fc9d6684dc4b1c62fd5f62.1504508375.git.shahafs@mellanox.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 13:25:14 -0000 Hi Shahaf, > } >=20 > +/** > + * A conversion function from rxmode offloads API to rte_eth_rxq_conf > + * offloads API. > + */ > +static void > +rte_eth_convert_rxmode_offloads(struct rte_eth_rxmode *rxmode, > + struct rte_eth_rxq_conf *rxq_conf) > +{ > + if (rxmode->header_split =3D=3D 1) > + rxq_conf->offloads |=3D DEV_RX_OFFLOAD_HEADER_SPLIT; > + if (rxmode->hw_ip_checksum =3D=3D 1) > + rxq_conf->offloads |=3D DEV_RX_OFFLOAD_CHECKSUM; > + if (rxmode->hw_vlan_filter =3D=3D 1) > + rxq_conf->offloads |=3D DEV_RX_OFFLOAD_VLAN_FILTER; Thinking on it a bit more: VLAN_FILTER is definitely one per device, as it would affect VFs also. At least that's what we have for Intel devices (ixgbe, i40e) right now. For Intel devices VLAN_STRIP is also per device and will also be applied to all corresponding VFs. In fact, right now it is possible to query/change these 3 vlan offload flag= s on the fly (after dev_start) on port basis by rte_eth_dev_(get|set)_vlan_offload API. So, I think at least these 3 flags need to be remained on a port basis. In fact, why can't we have both per port and per queue RX offload: - dev_configure() will accept RX_OFFLOAD_* flags and apply them on a port b= asis. - rx_queue_setup() will also accept RX_OFFLOAD_* flags and apply them on a = queue basis. - if particular RX_OFFLOAD flag for that device couldn't be setup on a queu= e basis - rx_queue_setup() will return an error. - rte_eth_rxq_info can be extended to provide information which RX_OFFLOADs can be configured on a per queue basis. BTW - in that case we probably wouldn't need ignore flag inside rx_conf any= more. > + if (rxmode->hw_vlan_strip =3D=3D 1) > + rxq_conf->offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; > + if (rxmode->hw_vlan_extend =3D=3D 1) > + rxq_conf->offloads |=3D DEV_RX_OFFLOAD_VLAN_EXTEND; > + if (rxmode->jumbo_frame =3D=3D 1) > + rxq_conf->offloads |=3D DEV_RX_OFFLOAD_JUMBO_FRAME; There are some extra checks for that flag inside rte_eth_dev_configure(). If we going so support it per queue - then it probably need to be updated.= =20 > + if (rxmode->hw_strip_crc =3D=3D 1) > + rxq_conf->offloads |=3D DEV_RX_OFFLOAD_CRC_STRIP; > + if (rxmode->enable_scatter =3D=3D 1) > + rxq_conf->offloads |=3D DEV_RX_OFFLOAD_SCATTER; > + if (rxmode->enable_lro =3D=3D 1) > + rxq_conf->offloads |=3D DEV_RX_OFFLOAD_TCP_LRO; > +} > + Konstantin