From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 4E07E7CE5; Thu, 21 Sep 2017 00:46:21 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP; 20 Sep 2017 15:46:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,422,1500966000"; d="scan'208";a="1197356968" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 20 Sep 2017 15:46:19 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 20 Sep 2017 23:46:19 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by IRSMSX156.ger.corp.intel.com ([169.254.3.33]) with mapi id 14.03.0319.002; Wed, 20 Sep 2017 23:46:19 +0100 From: "Ananyev, Konstantin" To: "Dai, Wei" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when port is stopped Thread-Index: AQHTMckXQh/D9iBJlUeURaEc/zTtQKK9f75AgABEuYCAAJi18A== Date: Wed, 20 Sep 2017 22:46:17 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772584F24D80D@irsmsx105.ger.corp.intel.com> References: <1505873529-64121-1-git-send-email-wei.dai@intel.com> <1505881001-12200-1-git-send-email-wei.dai@intel.com> <2601191342CEEE43887BDE71AB9772584F24D244@irsmsx105.ger.corp.intel.com> <49759EB36A64CF4892C1AFEC9231E8D650B9A377@PGSMSX106.gar.corp.intel.com> In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650B9A377@PGSMSX106.gar.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQ2OGYxYzYtNWMzNC00MTE5LTlkODctMTA3NmE4M2M2ZTYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtCcWtDK25TaGM0UU94bzFNSTlzazQzRENDRzMrWGFCQ3pCdGxDTU9FZzg9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when port is stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2017 22:46:23 -0000 Hi Wei, >=20 > Hi, Konstantin >=20 > Without this patch, when a port is stopped, all mirror SW resource are cl= eared but HW settings are still there. > And once the port is started again, creating mirror rule may fail due to = remain HW settings. >=20 > There is a testpmd use case which can show why this patch is needed. > 1. bind PF to igb_uio > #/root/dpdk-devbind.py -b igb_uio 0000:08:00.0 > 2. create 2 VFs > #echo 2 > /sys/bus/pci/devices/0000\:08\:00.0/max_vfs > 3. launch testpmd with PF, and set port mirror configuration > #./x86_64-native-linuxapp-gcc/app/testpmd -c 3 -n 4 -- -i > Testpmd > set port 0 mirror-rule 0 pool-mirror-up 0x1 dst-pool 1 on > Testpmd > quit > 4. relaunch testpmd with PF, and set port mirror as the same configuratio= n > #./x86_64-native-linuxapp-gcc/app/testpmd -c 3 -n 4 -- -i > Testpmd > set port 0 mirror-rule 0 pool-mirror-up 0x1 dst-pool 1 on > I40e_mirror_rule_set( ): failed to add mirror rule: ret =3D -53, aq_err = =3D 13. > Mirror rule add error: (Function not implemented) >=20 > When testpmd is quitted, rte_eth_dev_stop( ) and then rte_eth_dev_close( = ) are called. > In these function, i40e_dev_stop( ) and i40e_dev_close( ) is called. > And i40e_dev_stop is also called by i40e_dev_close( ). >=20 > Without this patch, the error in second running of testpmd always happen. > This patch can address this error. Thanks for explanation. Though it seems that the patch while fixing the issue might introduce some = inconsistences: 1. right now for i40e: dev_stop(port); dev_start(port) would keep existing = HW mirror rule working. With your patch is not any more. 2. What about ixgbe? Do we also need to change its behavior? As I can see right now ixgbe doesn't reset any mirror rules at dev_stop= (). Would it be reset automatically, or do we need to update ixgbe PMD too? About #1 - if we'll decide that this is a desired behavior that dev_stop() = voids=20 all mirror rules, then at least we probably need to update the documentatio= n. As alternative - at dev_stop() we can reset only actual HW rule, but keep S= W configuration intact, and restore them at dev_start(). I personally think second option is a bit better - as it preserves existing= behavior, and probably more convenient for the user. About the patch itself, why just not: while ((p_mirror =3D TAILQ_FIRST(&pf->mirror_list)))=20 i40e_mirror_rule_reset(dev, p_mirror->index); ? Konstantin =20 =20 >=20 > > -----Original Message----- > > From: Ananyev, Konstantin > > Sent: Wednesday, September 20, 2017 5:23 PM > > To: Dai, Wei ; Wu, Jingjing ; > > Xing, Beilei > > Cc: dev@dpdk.org; Dai, Wei ; stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when= port > > is stopped > > > > Hi Wei, > > > > > > > > When an i40e PF port is stopped, all mirror rules should be removed. > > > All rule related software and hardware resources should also be > > > removed. > > > > Could you clarify why we have to remove all mirror rules when PF is > > stopped? > > As I remember mirror rule can direct to VF, which still can be running,= no? > > Konstantin > > > > > > > > Fixes: a4def5edf0fc ("i40e: enable port mirroring") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Wei Dai > > > Tested-by: Lijuan Tu > > > --- > > > drivers/net/i40e/i40e_ethdev.c | 21 ++++++++++++++++++++- > > > 1 file changed, 20 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > > b/drivers/net/i40e/i40e_ethdev.c index f12aefa..14cf6c0 100644 > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > @@ -361,6 +361,12 @@ static int i40e_dev_sync_phy_type(struct > > i40e_hw > > > *hw); static void i40e_configure_registers(struct i40e_hw *hw); > > > static void i40e_hw_init(struct rte_eth_dev *dev); static int > > > i40e_config_qinq(struct i40e_hw *hw, struct i40e_vsi *vsi); > > > +static enum i40e_status_code i40e_aq_del_mirror_rule(struct i40e_hw > > *hw, > > > + uint16_t seid, > > > + uint16_t rule_type, > > > + uint16_t *entries, > > > + uint16_t count, > > > + uint16_t rule_id); > > > static int i40e_mirror_rule_set(struct rte_eth_dev *dev, > > > struct rte_eth_mirror_conf *mirror_conf, > > > uint8_t sw_id, uint8_t on); > > > @@ -2069,6 +2075,7 @@ i40e_dev_stop(struct rte_eth_dev *dev) > > > struct rte_pci_device *pci_dev =3D RTE_ETH_DEV_TO_PCI(dev); > > > struct rte_intr_handle *intr_handle =3D &pci_dev->intr_handle; > > > int i; > > > + int ret; > > > > > > if (hw->adapter_stopped =3D=3D 1) > > > return; > > > @@ -2096,10 +2103,22 @@ i40e_dev_stop(struct rte_eth_dev *dev) > > > > > > /* Remove all mirror rules */ > > > while ((p_mirror =3D TAILQ_FIRST(&pf->mirror_list))) { > > > + ret =3D i40e_aq_del_mirror_rule(hw, > > > + pf->main_vsi->veb->seid, > > > + p_mirror->rule_type, > > > + p_mirror->entries, > > > + p_mirror->num_entries, > > > + p_mirror->id); > > > + if (ret < 0) > > > + PMD_DRV_LOG(ERR, "failed to remove mirror rule: " > > > + "status =3D %d, aq_err =3D %d.", ret, > > > + hw->aq.asq_last_status); > > > + > > > + /* remove mirror software resource any way */ > > > TAILQ_REMOVE(&pf->mirror_list, p_mirror, rules); > > > rte_free(p_mirror); > > > + pf->nb_mirror_rule--; > > > } > > > - pf->nb_mirror_rule =3D 0; > > > > > > if (!rte_intr_allow_others(intr_handle)) > > > /* resume to the default handler */ > > > -- > > > 2.7.5