From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 89D371B1B8 for ; Mon, 2 Oct 2017 11:36:03 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2017 02:36:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,468,1500966000"; d="scan'208";a="141664303" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga002.jf.intel.com with ESMTP; 02 Oct 2017 02:35:52 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Mon, 2 Oct 2017 10:35:51 +0100 From: "Ananyev, Konstantin" To: "Ananyev, Konstantin" , "Li, Xiaoyun" , "Richardson, Bruce" CC: "Lu, Wenzhuo" , "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 3/3] efd: run-time dispatch over x86 EFD functions Thread-Index: AQHTOxKiGWIW0brHN0OikyeYeXTxFKLQTISg Date: Mon, 2 Oct 2017 09:35:51 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FAA2CE5@IRSMSX103.ger.corp.intel.com> References: <1506411689-94690-1-git-send-email-xiaoyun.li@intel.com> <1506411689-94690-4-git-send-email-xiaoyun.li@intel.com> <2601191342CEEE43887BDE71AB9772585FAA2BFF@IRSMSX103.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAA2BFF@IRSMSX103.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTFjMWU1YjUtNDA0My00MDVmLTljMTgtYmMzOWUxNTJjNjE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkpaZ0c1VzJFUUlnMEhXbmZJVlh4Sk5MTmliZFwvMm9QT09rSmxVZUN6RGI4PSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/3] efd: run-time dispatch over x86 EFD functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 09:36:05 -0000 >=20 > > > > This patch dynamically selects x86 EFD functions at run-time. >=20 > I don't think it really does. > In fact, I am not sure that we need to touch EFD at all here - > from what I can see, it already does dynamic selection properly. Actually I was wrong here - in some cases it doesn't work properly. As I can see for default target proper avx2 code wouldn't be compiled. So some work still needed here - same as for memcpy(). Konstantin > Konstantin >=20 > > This patch uses function pointer and binds it to the relative > > function based on CPU flags at constructor time. > > > > Signed-off-by: Xiaoyun Li > > --- > > lib/librte_efd/rte_efd_x86.h | 41 ++++++++++++++++++++++++++++++++++++= ++--- > > 1 file changed, 38 insertions(+), 3 deletions(-) > > > > diff --git a/lib/librte_efd/rte_efd_x86.h b/lib/librte_efd/rte_efd_x86.= h > > index 34f37d7..93b6743 100644 > > --- a/lib/librte_efd/rte_efd_x86.h > > +++ b/lib/librte_efd/rte_efd_x86.h > > @@ -43,12 +43,29 @@ > > #define EFD_LOAD_SI128(val) _mm_lddqu_si128(val) > > #endif > > > > +typedef efd_value_t > > +(*efd_lookup_internal_avx2_t)(const efd_hashfunc_t *group_hash_idx, > > + const efd_lookuptbl_t *group_lookup_table, > > + const uint32_t hash_val_a, const uint32_t hash_val_b); > > + > > +static efd_lookup_internal_avx2_t efd_lookup_internal_avx2_ptr; > > + > > static inline efd_value_t > > efd_lookup_internal_avx2(const efd_hashfunc_t *group_hash_idx, > > const efd_lookuptbl_t *group_lookup_table, > > const uint32_t hash_val_a, const uint32_t hash_val_b) > > { > > -#ifdef RTE_MACHINE_CPUFLAG_AVX2 > > + return (*efd_lookup_internal_avx2_ptr)(group_hash_idx, > > + group_lookup_table, > > + hash_val_a, hash_val_b); > > +} > > + > > +#ifdef CC_SUPPORT_AVX2 > > +static inline efd_value_t > > +efd_lookup_internal_avx2_AVX2(const efd_hashfunc_t *group_hash_idx, > > + const efd_lookuptbl_t *group_lookup_table, > > + const uint32_t hash_val_a, const uint32_t hash_val_b) > > +{ > > efd_value_t value =3D 0; > > uint32_t i =3D 0; > > __m256i vhash_val_a =3D _mm256_set1_epi32(hash_val_a); > > @@ -74,13 +91,31 @@ efd_lookup_internal_avx2(const efd_hashfunc_t *grou= p_hash_idx, > > } > > > > return value; > > -#else > > +} > > +#endif > > + > > +static inline efd_value_t > > +efd_lookup_internal_avx2_DEFAULT(const efd_hashfunc_t *group_hash_idx, > > + const efd_lookuptbl_t *group_lookup_table, > > + const uint32_t hash_val_a, const uint32_t hash_val_b) > > +{ > > RTE_SET_USED(group_hash_idx); > > RTE_SET_USED(group_lookup_table); > > RTE_SET_USED(hash_val_a); > > RTE_SET_USED(hash_val_b); > > /* Return dummy value, only to avoid compilation breakage */ > > return 0; > > -#endif > > +} > > > > +static void __attribute__((constructor)) > > +rte_efd_x86_init(void) > > +{ > > +#ifdef CC_SUPPORT_AVX2 > > + if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)) > > + efd_lookup_internal_avx2_ptr =3D efd_lookup_internal_avx2_AVX2; > > + else > > + efd_lookup_internal_avx2_ptr =3D efd_lookup_internal_avx2_DEFAULT; > > +#else > > + efd_lookup_internal_avx2_ptr =3D efd_lookup_internal_avx2_DEFAULT; > > +#endif > > } > > -- > > 2.7.4