From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B6A921B65E for ; Wed, 4 Oct 2017 16:15:43 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2017 07:15:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,477,1500966000"; d="scan'208";a="1178593083" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga001.jf.intel.com with ESMTP; 04 Oct 2017 07:15:41 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX106.ger.corp.intel.com ([169.254.8.36]) with mapi id 14.03.0319.002; Wed, 4 Oct 2017 15:15:40 +0100 From: "Ananyev, Konstantin" To: "Kavanagh, Mark B" , "dev@dpdk.org" CC: "Hu, Jiayu" , "Tan, Jianfeng" , "Yigit, Ferruh" , "thomas@monjalon.net" Thread-Topic: [PATCH v6 4/6] gso: add GRE GSO support Thread-Index: AQHTO536XcyjZ5ySnkKAchGxjLt1AKLTvvaA Date: Wed, 4 Oct 2017 14:15:39 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FAA3E00@IRSMSX103.ger.corp.intel.com> References: <1506636833-25851-1-git-send-email-mark.b.kavanagh@intel.com> <1506962749-106779-1-git-send-email-mark.b.kavanagh@intel.com> <1506962749-106779-5-git-send-email-mark.b.kavanagh@intel.com> In-Reply-To: <1506962749-106779-5-git-send-email-mark.b.kavanagh@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmQ1YTI0NGEtNTU4ZS00MjhjLWJiYjktOTRlNWY2ZDcyNzZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ing4aDZxOGlrT2VXWThHcTFMODVUOWwwZVhHTkU2cEthelJURjZwaStvaWM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 4/6] gso: add GRE GSO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 14:15:44 -0000 > diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c > index 6095689..b748ab1 100644 > --- a/lib/librte_gso/rte_gso.c > +++ b/lib/librte_gso/rte_gso.c > @@ -60,8 +60,9 @@ >=20 > if ((gso_ctx->gso_size >=3D pkt->pkt_len) || (gso_ctx->gso_types & > (DEV_TX_OFFLOAD_TCP_TSO | > - DEV_TX_OFFLOAD_VXLAN_TNL_TSO)) !=3D > - gso_ctx->gso_types) { > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > + DEV_TX_OFFLOAD_GRE_TNL_TSO)) !=3D > + gso_ctx->gso_types) { > pkt->ol_flags &=3D (~PKT_TX_TCP_SEG); > pkts_out[0] =3D pkt; > return 1; > @@ -73,7 +74,8 @@ > ipid_delta =3D (gso_ctx->ipid_flag !=3D RTE_GSO_IPID_FIXED); > ol_flags =3D pkt->ol_flags; >=20 > - if (IS_IPV4_VXLAN_TCP4(pkt->ol_flags)) { > + if (IS_IPV4_VXLAN_TCP4(pkt->ol_flags) || > + IS_IPV4_GRE_TCP4(pkt->ol_flags)) { Same comment as for previous patch: user might want that ctx to=20 Segment vxlan packets and not segment gro packets. Konstantin > pkt->ol_flags &=3D (~PKT_TX_TCP_SEG); > ret =3D gso_tunnel_tcp4_segment(pkt, gso_size, ipid_delta, > direct_pool, indirect_pool, > -- > 1.9.3