From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 276061B66C
for <dev@dpdk.org>; Fri, 13 Oct 2017 12:26:39 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
13 Oct 2017 03:26:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,370,1503385200"; d="scan'208";a="138102633"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
by orsmga004.jf.intel.com with ESMTP; 13 Oct 2017 03:26:38 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by
IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002;
Fri, 13 Oct 2017 11:26:32 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Li, Xiaoyun" <xiaoyun.li@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce"
<bruce.richardson@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Zhang,
Helin" <helin.zhang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy
Thread-Index: AQHTRAImhtVu8Wh2TUmXY3+ab3yexaLhcosAgAAZh0A=
Date: Fri, 13 Oct 2017 10:26:32 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772585FAA8BB1@IRSMSX103.ger.corp.intel.com>
References: <1507206794-79941-1-git-send-email-xiaoyun.li@intel.com>
<1507885309-165144-1-git-send-email-xiaoyun.li@intel.com>
<1507885309-165144-2-git-send-email-xiaoyun.li@intel.com>
<31420042.6nB00FbIV6@xps>
In-Reply-To: <31420042.6nB00FbIV6@xps>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDA4NTdlZWItZTg2My00NmY4LWEwNTgtZGIzNWRlZWI1NDE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Iis0a2ZSYW84c0dycDNzZUNOdHg0UklGZm5hY3BxWUU2Y1JtazVFNG5sSWM9In0=
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Oct 2017 10:26:40 -0000
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, October 13, 2017 10:29 AM
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Ananyev, Konstantin <konstantin.a=
nanyev@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Lu, Wen=
zhuo <wenzhuo.lu@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over me=
mcpy
>=20
> 13/10/2017 11:01, Xiaoyun Li:
> > lib/librte_eal/common/arch/x86/rte_memcpy.c | 59 ++
> > lib/librte_eal/common/arch/x86/rte_memcpy_avx2.c | 44 +
> > .../common/arch/x86/rte_memcpy_avx512f.c | 44 +
> > lib/librte_eal/common/arch/x86/rte_memcpy_sse.c | 40 +
> > .../common/include/arch/x86/rte_memcpy.h | 861 +------------=
-----
> > .../common/include/arch/x86/rte_memcpy_internal.h | 966 +++++++++++++=
++++++++
>=20
> I think that rte_memcpy_internal.h should not be in the include directory=
.
> Can it be moved to lib/librte_eal/common/arch/ ?
I am afraid we can't - for size < 128 bytes we still use inline version of =
memcpy -
to avoid perfomance regression.
So we still need that file to stay in include dir.
>=20
> > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> > @@ -243,6 +243,7 @@ DPDK_17.11 {
> > rte_eal_iova_mode;
> > rte_eal_mbuf_default_mempool_ops;
> > rte_lcore_has_role;
> > + rte_memcpy_ptr;
>=20
> I don't know what is the consequence of adding this function in the .map
> file for architectures where it does not exist?
I don't have arm/ppc box to try...
Though I tried to add unexciting function name into
lib/librte_eal/linuxapp/eal/rte_eal_version.map.
Didn't encounter any problems.=20
So my guess - it is harmless.
Konstantin