From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 243CD2BAE for ; Mon, 11 Dec 2017 16:03:44 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 07:03:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="1835866" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga007.jf.intel.com with ESMTP; 11 Dec 2017 07:03:42 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.67]) by IRSMSX103.ger.corp.intel.com ([169.254.3.49]) with mapi id 14.03.0319.002; Mon, 11 Dec 2017 15:03:41 +0000 From: "Ananyev, Konstantin" To: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 14/39] examples/ip_reassembly: convert to new ethdev offloads API Thread-Index: AQHTZFWHcjeFvuv4p0OkxiHNRhi7bqM+WLHw Date: Mon, 11 Dec 2017 15:03:41 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FAC8030@irsmsx105.ger.corp.intel.com> References: <20171123121941.144335-1-shahafs@mellanox.com> <20171123121941.144335-5-shahafs@mellanox.com> In-Reply-To: <20171123121941.144335-5-shahafs@mellanox.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDIzNGZlMzAtNmZlOS00YzA1LWExZjMtNjhlZmQ4MGRmMDRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZ0dlkzdUEybTFVS2FGOUZmR09HcXZid3lWeGcxdmlla2Rkb1wvdVVEWUljPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 14/39] examples/ip_reassembly: convert to new ethdev offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 15:03:45 -0000 Hi Shahaf, > + if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) !=3D > + port_conf.rxmode.offloads) { > + printf("Some Rx offloads are not supported " > + "by port %d: requested 0x%lx supported 0x%lx\n", > + portid, port_conf.rxmode.offloads, > + dev_info.rx_offload_capa); > + port_conf.rxmode.offloads &=3D dev_info.rx_offload_capa; > + } > + if ((dev_info.tx_offload_capa & port_conf.txmode.offloads) !=3D > + port_conf.txmode.offloads) { > + printf("Some Tx offloads are not supported " > + "by port %d: requested 0x%lx supported 0x%lx\n", > + portid, port_conf.txmode.offloads, > + dev_info.tx_offload_capa); > + port_conf.txmode.offloads &=3D dev_info.tx_offload_capa; > + } Sort of generic question regarding most examples - wouldn't it be better to= do rte_exit() if device doesn't support the offloads we expect instead of masking off unsupported offloads = and continue? Konstantin=20 > ret =3D rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue, > &port_conf);