From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 377991C00 for ; Wed, 13 Dec 2017 13:10:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2017 04:10:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,397,1508828400"; d="scan'208";a="2375071" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga007.jf.intel.com with ESMTP; 13 Dec 2017 04:10:27 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.67]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Wed, 13 Dec 2017 12:10:26 +0000 From: "Ananyev, Konstantin" To: Jerin Jacob , Shahaf Shuler CC: "dev@dpdk.org" , "Nicolau, Radu" , "arybchenko@solarflare.com" Thread-Topic: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API Thread-Index: AQHTc0SgHaoN9+BZnUSY12TzfaHepqM/8IAAgADu0YCAAAmWgIAARORQ Date: Wed, 13 Dec 2017 12:10:26 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FAC9140@irsmsx105.ger.corp.intel.com> References: <20171123121419.144132-1-shahafs@mellanox.com> <2601191342CEEE43887BDE71AB9772585FAC8AEB@irsmsx105.ger.corp.intel.com> <20171213075518.GA18228@jerin> In-Reply-To: <20171213075518.GA18228@jerin> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWFmZjJkYjYtZGRlOS00ZGU5LTkzMzgtMzdhYjhiNzFkZDUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikp5QzVDYUxTMWt5K0loNWVPeGd3VStMcERHTDNiR3d3MHpMVmEyeHY2VzQ9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 12:10:30 -0000 Hi Jerin, > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Wednesday, December 13, 2017 7:55 AM > To: Shahaf Shuler > Cc: Ananyev, Konstantin ; dev@dpdk.org; Nic= olau, Radu ; > arybchenko@solarflare.com > Subject: Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev o= ffloads API >=20 > -----Original Message----- > > Date: Wed, 13 Dec 2017 07:21:01 +0000 > > From: Shahaf Shuler > > To: "Ananyev, Konstantin" , "dev@dpdk.org= " > > , "Nicolau, Radu" , > > "arybchenko@solarflare.com" > > Subject: Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev > > offloads API > > > > Tuesday, December 12, 2017 7:12 PM, Ananyev, Konstantin: > > > > -----Original Message----- > > > > From: Shahaf Shuler [mailto:shahafs@mellanox.com] > > > > Sent: Tuesday, December 12, 2017 12:26 PM > > > > To: dev@dpdk.org; Ananyev, Konstantin > > > ; > > > > Nicolau, Radu ; arybchenko@solarflare.com > > > > Subject: [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads A= PI > > > > > > > > Ethdev offloads API has changed since: > > > > > > > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") com= mit > > > > cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > > > > > > > This commit support the new API. > > > > > > > > Signed-off-by: Shahaf Shuler > > > > --- > > > > examples/l3fwd/main.c | 40 ++++++++++++++++++++++++++++++-------- > > > -- > > > > 1 file changed, 30 insertions(+), 10 deletions(-) > > > > > > > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index > > > > 6229568..3bdf4d5 100644 > > > > --- a/examples/l3fwd/main.c > > > > +++ b/examples/l3fwd/main.c > > > > @@ -149,11 +149,9 @@ struct lcore_params { > > > > .mq_mode =3D ETH_MQ_RX_RSS, > > > > .max_rx_pkt_len =3D ETHER_MAX_LEN, > > > > .split_hdr_size =3D 0, > > > > - .header_split =3D 0, /**< Header Split disabled */ > > > > - .hw_ip_checksum =3D 1, /**< IP checksum offload enabled */ > > > > - .hw_vlan_filter =3D 0, /**< VLAN filtering disabled */ > > > > - .jumbo_frame =3D 0, /**< Jumbo Frame Support disabled */ > > > > - .hw_strip_crc =3D 1, /**< CRC stripped by hardware */ > > > > + .ignore_offload_bitfield =3D 1, > > > > + .offloads =3D (DEV_RX_OFFLOAD_CRC_STRIP | > > > > + DEV_RX_OFFLOAD_CHECKSUM), > > > > }, > > > > .rx_adv_conf =3D { > > > > .rss_conf =3D { > > > > @@ -163,6 +161,7 @@ struct lcore_params { > > > > }, > > > > .txmode =3D { > > > > .mq_mode =3D ETH_MQ_TX_NONE, > > > > + .offloads =3D DEV_TX_OFFLOAD_MBUF_FAST_FREE, > > > > > > Hmm, does it mean a new warning for all PMDs (majority) which don't > > > support DEV_TX_OFFLOAD_MBUF_FAST_FREE? > > > > Good point. > > Unlike other offloads which are must for the application proper run, th= is one it only for optimizing the performance and should be set only > if PMD supports. > > Am continuing to aggregate reasons why the DEV_TX_OFFLOAD_MBUF_FAST_FRE= E should not be defined as an offload. Anyway we > passed that... > > > > I will fix on v3. >=20 > Removing is not an option as the PMDs rely on that flag to will have the > impact. > # I see DEV_TX_OFFLOAD_MBUF_FAST_FREE as hint driver to depict the applic= ation requirements > # All the drivers by default can support DEV_TX_OFFLOAD_MBUF_FAST_FREE(Th= ey are using the hint or > not is a different question) >=20 > So, How about setting DEV_TX_OFFLOAD_MBUF_FAST_FREE in all PMD driver as > dummy one? I think, currently, it can be moved to old API to new API > transition function till the drivers change to new offload flag scheme. I don't think anyone plans to remove it right now. If you believe your PMD does need it, that's ok by me. Though I still think it is a very limited usage for it, and I don't think we have to make that flag supported by all PMDs. Konstantin >=20 > We are planning to change nicvf driver to new offload scheme for this > release so with this change, we have the performance impact on l3fwd > application. >=20 > I think, the other option could be to change usage/meaning of > DEV_TX_OFFLOAD_MBUF_FAST_FREE flag where when the application needs > multi-pool and reference count scheme then "it sets" the offload flags. > If so, we don't need to set by default on the these applications.