From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5C7151B01C for ; Fri, 15 Dec 2017 11:58:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Dec 2017 02:58:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,404,1508828400"; d="scan'208";a="12537426" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga003.jf.intel.com with ESMTP; 15 Dec 2017 02:58:32 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.67]) by IRSMSX154.ger.corp.intel.com ([169.254.12.83]) with mapi id 14.03.0319.002; Fri, 15 Dec 2017 10:58:10 +0000 From: "Ananyev, Konstantin" To: Pavan Nikhilesh Bhagavatula , "jerin.jacob@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" , "Richardson, Bruce" , "Van Haaren, Harry" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros Thread-Index: AQHTdOyZUAPCJF8ezkSgc6sw+hJ8a6NDLMfggADw4QCAAB42kA== Date: Fri, 15 Dec 2017 10:58:10 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FAC9DFF@irsmsx105.ger.corp.intel.com> References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <20171214150138.25667-1-pbhagavatula@caviumnetworks.com> <20171214150138.25667-2-pbhagavatula@caviumnetworks.com> <2601191342CEEE43887BDE71AB9772585FAC9A88@irsmsx105.ger.corp.intel.com> <20171215090445.huivudbztoxknb3j@Pavan-LT> In-Reply-To: <20171215090445.huivudbztoxknb3j@Pavan-LT> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTVhYmM5NTAtYjMyMC00OGFjLWEzMTAtYTRmYzExNzRkYTA1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFDR3loMTg0RVBPQ1Z5NCtRS05MdmM3MTJJYkxvbHdOOTVXM3E2TGo3eWs9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2017 10:58:35 -0000 > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com= ] > Sent: Friday, December 15, 2017 9:05 AM > To: Ananyev, Konstantin ; jerin.jacob@caviu= mnetworks.com; santosh.shukla@caviumnetworks.com; > Richardson, Bruce ; Van Haaren, Harry ; Eads, Gage ; > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macr= os >=20 > On Thu, Dec 14, 2017 at 06:43:24PM +0000, Ananyev, Konstantin wrote: > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavan Nikhilesh > > > Sent: Thursday, December 14, 2017 3:01 PM > > > To: jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com= ; Richardson, Bruce ; Van > > > Haaren, Harry ; Eads, Gage ; hemant.agrawal@nxp.com; nipun.gupta@nxp.com; > > > Ma, Liang J > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > > Subject: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macr= os > > > > > > Adding common test assertion macros for unit testing. > > > > Wonder what's wrong with existing RTE_ASSERT() and RTE_VERIFY()? > > Konstantin >=20 > The existing RTE_ASSERT/VERIFY use rte_panic(). Yes, and wouldn't you expect that behavior from assert() call? Seriously where do you plan to use it outside auto test framework? Konstantin >=20 > Pavan > > > > > Taken from test/test.h. > > > > > > Signed-off-by: Pavan Nikhilesh > > > --- > > > lib/librte_eal/common/Makefile | 2 +- > > > lib/librte_eal/common/include/rte_test.h | 97 ++++++++++++++++++++++= ++++++++++ > > > 2 files changed, 98 insertions(+), 1 deletion(-) > > > create mode 100644 lib/librte_eal/common/include/rte_test.h > > > > > > diff --git a/lib/librte_eal/common/Makefile b/lib/librte_eal/common/M= akefile > > > index 9effd0d45..eba1059f2 100644 > > > --- a/lib/librte_eal/common/Makefile > > > +++ b/lib/librte_eal/common/Makefile > > > @@ -43,7 +43,7 @@ INC +=3D rte_hexdump.h rte_devargs.h rte_bus.h rte_= dev.h > > > INC +=3D rte_pci_dev_feature_defs.h rte_pci_dev_features.h > > > INC +=3D rte_malloc.h rte_keepalive.h rte_time.h > > > INC +=3D rte_service.h rte_service_component.h > > > -INC +=3D rte_bitmap.h rte_vfio.h > > > +INC +=3D rte_bitmap.h rte_vfio.h rte_test.h > > > > > > GENERIC_INC :=3D rte_atomic.h rte_byteorder.h rte_cycles.h rte_prefe= tch.h > > > GENERIC_INC +=3D rte_spinlock.h rte_memcpy.h rte_cpuflags.h rte_rwlo= ck.h > > > diff --git a/lib/librte_eal/common/include/rte_test.h b/lib/librte_ea= l/common/include/rte_test.h > > > new file mode 100644 > > > index 000000000..256117f79 > > > --- /dev/null > > > +++ b/lib/librte_eal/common/include/rte_test.h > > > @@ -0,0 +1,97 @@ > [...]