From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id BBF881B783 for ; Thu, 8 Feb 2018 13:13:58 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 04:13:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,478,1511856000"; d="scan'208";a="16273585" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga007.fm.intel.com with ESMTP; 08 Feb 2018 04:13:56 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.221]) by irsmsx110.ger.corp.intel.com ([169.254.15.15]) with mapi id 14.03.0319.002; Thu, 8 Feb 2018 12:13:55 +0000 From: "Ananyev, Konstantin" To: "Yigit, Ferruh" , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , Thomas Monjalon , "motih@mellanox.com" , "shahafs@mellanox.com" Thread-Topic: [PATCH] app/testpmd: enable CRC strip without capability check Thread-Index: AQHToNWRmRSxjEKmEkqiLSgrf58w+KOaatgA Date: Thu, 8 Feb 2018 12:13:54 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725890570935@irsmsx105.ger.corp.intel.com> References: <20180208120803.95060-1-ferruh.yigit@intel.com> In-Reply-To: <20180208120803.95060-1-ferruh.yigit@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2E2YmU3NDQtZTJhOC00MmU5LTlkNGUtODUwY2IwM2QzZGRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImZOQ0xrR0xMYWNrcXRLNitSWm1kK2tJSVdYdW1uUUZYZ0ZPd1BqaUpobFU9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: enable CRC strip without capability check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 12:13:59 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, February 8, 2018 12:08 PM > To: Lu, Wenzhuo ; Wu, Jingjing > Cc: dev@dpdk.org; Yigit, Ferruh ; Thomas Monjalon= ; Ananyev, Konstantin > ; motih@mellanox.com; shahafs@mellanox.com > Subject: [PATCH] app/testpmd: enable CRC strip without capability check >=20 > Some hardware doesn't support disabling CRC strip. In techboard it has > been decided to enable CRC strip always. >=20 > The testpmd update in commit 8b9bd0efe0b6, enables CRC strip only if > PMD reports CRC strip capability. Not all PMDs updated to report CRC > strip. >=20 > For the PMDs not reporting CRC strip testpmd behavior changed and > disabling CRC strip for them. And this may generate error for PMDs that > doesn't support disabling CRC strip. >=20 > Removing capability check for this release. In long term there can be > option to remove CRC strip flag completely or adding a new flag to let > PMD say disabling is not supported. >=20 > Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by default") >=20 > Signed-off-by: Ferruh Yigit > --- > Cc: motih@mellanox.com > Cc: shahafs@mellanox.com > --- > app/test-pmd/testpmd.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 46dc22c94..4c0e2586c 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -694,10 +694,6 @@ init_config(void) > DEV_TX_OFFLOAD_MBUF_FAST_FREE)) > port->dev_conf.txmode.offloads &=3D > ~DEV_TX_OFFLOAD_MBUF_FAST_FREE; > - if (!(port->dev_info.rx_offload_capa & > - DEV_RX_OFFLOAD_CRC_STRIP)) > - port->dev_conf.rxmode.offloads &=3D > - ~DEV_RX_OFFLOAD_CRC_STRIP; > if (numa_support) { > if (port_numa[pid] !=3D NUMA_NO_CONFIG) > port_per_socket[port_numa[pid]]++; > -- Acked-by: Konstantin Ananyev > 2.14.3