DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Awal, Mohammad Abdul" <mohammad.abdul.awal@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "rkerur@gmail.com" <rkerur@gmail.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Awal, Mohammad Abdul" <mohammad.abdul.awal@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ether: fix invalid string length in ethdev name	comparison
Date: Tue, 27 Feb 2018 00:15:01 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725890578299@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1519687296-2872-1-git-send-email-mohammad.abdul.awal@intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mohammad Abdul Awal
> Sent: Monday, February 26, 2018 11:22 PM
> To: thomas@monjalon.net
> Cc: rkerur@gmail.com; dev@dpdk.org; Awal, Mohammad Abdul <mohammad.abdul.awal@intel.com>
> Subject: [dpdk-dev] [PATCH] ether: fix invalid string length in ethdev name comparison
> 
> The current code compares two strings upto the length of 1st string
> (searched name). If the 1st string is prefix of 2nd string (existing name),
> the string comparison returns the port_id of earliest prefix matches.
> This patch fixes the bug by comparing the strings upto the length of larger
> string.
> 
> Fixes: 9c5b8d8b9fe ("ethdev: clean port id retrieval when attaching")
> 
> Signed-off-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> ---
>  lib/librte_ether/rte_ethdev.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 0590f0c..8e8097b 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -563,17 +563,20 @@ rte_eth_dev_get_name_by_port(uint16_t port_id, char *name)
>  int
>  rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id)
>  {
> -	uint32_t pid;
> +	uint32_t pid, len, len1, len2;
> 
>  	if (name == NULL) {
>  		RTE_PMD_DEBUG_TRACE("Null pointer is specified\n");
>  		return -EINVAL;
>  	}
> 
> +	len1 = strlen(name);
>  	for (pid = 0; pid < RTE_MAX_ETHPORTS; pid++) {
> +		len2 = strlen(rte_eth_dev_shared_data->data[pid].name);
> +		len = len1 > len2 ? len1 : len2;
>  		if (rte_eth_devices[pid].state != RTE_ETH_DEV_UNUSED &&
>  		    !strncmp(name, rte_eth_dev_shared_data->data[pid].name,
> -			     strlen(name))) {
> +			     len)) {

Why just not simply use strcmp()? :)

>  			*port_id = pid;
>  			return 0;
>  		}
> --
> 2.7.4

  reply	other threads:[~2018-02-27  0:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 23:21 Mohammad Abdul Awal
2018-02-27  0:15 ` Ananyev, Konstantin [this message]
2018-02-27  8:51   ` Mohammad Abdul Awal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB97725890578299@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    --cc=mohammad.abdul.awal@intel.com \
    --cc=rkerur@gmail.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).