From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3FD015F5D for ; Wed, 14 Mar 2018 13:32:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 05:32:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,470,1515484800"; d="scan'208";a="211470531" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga005.fm.intel.com with ESMTP; 14 Mar 2018 05:31:59 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.221]) by IRSMSX107.ger.corp.intel.com ([169.254.10.46]) with mapi id 14.03.0319.002; Wed, 14 Mar 2018 12:31:58 +0000 From: "Ananyev, Konstantin" To: "Zhang, Qi Z" , "thomas@monjalon.net" CC: "dev@dpdk.org" , "Xing, Beilei" , "Wu, Jingjing" , "Lu, Wenzhuo" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH v2 1/4] ether: support deferred queue setup Thread-Index: AQHTsdzYjJFpxTZzDkGudLbJsh6cp6PPudHg Date: Wed, 14 Mar 2018 12:31:58 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772589E28FA63@irsmsx105.ger.corp.intel.com> References: <20180212045314.171616-1-qi.z.zhang@intel.com> <20180302041306.90324-1-qi.z.zhang@intel.com> <20180302041306.90324-2-qi.z.zhang@intel.com> In-Reply-To: <20180302041306.90324-2-qi.z.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTNkNDhhMTItZDliNC00MmRmLWI0ODMtZjhjMjQyY2MwY2MxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkhkUlhBd0g1OTBLRERNXC9MdjRxY2FDYkJsaUpoNGdtWElNWFFvemEyS3FJPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ether: support deferred queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 12:32:03 -0000 Hi Qi, >=20 > The patch let etherdev driver expose the capability flag through > rte_eth_dev_info_get when it support deferred queue configuraiton, > then base on the flag rte_eth_[rx|tx]_queue_setup could decide > continue to setup the queue or just return fail when device already > started. >=20 > Signed-off-by: Qi Zhang > --- > doc/guides/nics/features.rst | 8 ++++++++ > lib/librte_ether/rte_ethdev.c | 30 ++++++++++++++++++------------ > lib/librte_ether/rte_ethdev.h | 11 +++++++++++ > 3 files changed, 37 insertions(+), 12 deletions(-) >=20 > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index 1b4fb979f..36ad21a1f 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -892,7 +892,15 @@ Documentation describes performance values. >=20 > See ``dpdk.org/doc/perf/*``. >=20 > +.. _nic_features_queue_deferred_setup_capabilities: >=20 > +Queue deferred setup capabilities > +--------------------------------- > + > +Supports queue setup / release after device started. > + > +* **[provides] rte_eth_dev_info**: > ``deferred_queue_config_capa:DEV_DEFERRED_RX_QUEUE_SETUP,DEV_DEFERRED_TX_= QUEUE_SETUP,DEV_DEFERRED_RX_QUEUE_RELE > ASE,DEV_DEFERRED_TX_QUEUE_RELEASE``. > +* **[related] API**: ``rte_eth_dev_info_get()``. >=20 > .. _nic_features_other: >=20 > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.= c > index a6ce2a5ba..6c906c4df 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -1425,12 +1425,6 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t = rx_queue_id, > return -EINVAL; > } >=20 > - if (dev->data->dev_started) { > - RTE_PMD_DEBUG_TRACE( > - "port %d must be stopped to allow configuration\n", port_id); > - return -EBUSY; > - } > - > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP); > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_setup, -ENOTSUP); >=20 > @@ -1474,10 +1468,19 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t= rx_queue_id, > return -EINVAL; > } >=20 > + if (dev->data->dev_started && > + !(dev_info.deferred_queue_config_capa & > + DEV_DEFERRED_RX_QUEUE_SETUP)) > + return -EINVAL; > + I think now you have to check here that the queue is stopped. Otherwise you might attempt to reconfigure running queue. > rxq =3D dev->data->rx_queues; > if (rxq[rx_queue_id]) { > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, > -ENOTSUP); I don't think it is *that* straightforward. rx_queue_setup() parameters can imply different rx function (and related de= v icesettings) that are already setuped by previous queue_setup()/dev_start. So I think you need to do one of 2 things: 1. rework ethdev layer to introduce a separate rx function (and related set= tings) for each queue. 2. at rx_queue_setup() if it is invoked after dev_start - check that given = queue settings wouldn't contradict with current device settings (rx function, etc.). If they do - return an error. >>From my perspective - 1) is a better choice though it required more work, a= nd possibly ABI breakage. I did some work in that direction as RFC: http://dpdk.org/dev/patchwork/patch/31866/ 2) might be also possible, but looks a bit clumsy as rx_queue_setup() might= now fail even with valid parameters - all depends on previous queue configurations. Same story applies for TX. > + if (dev->data->dev_started && > + !(dev_info.deferred_queue_config_capa & > + DEV_DEFERRED_RX_QUEUE_RELEASE)) > + return -EINVAL; > (*dev->dev_ops->rx_queue_release)(rxq[rx_queue_id]); > rxq[rx_queue_id] =3D NULL; > } > @@ -1573,12 +1576,6 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t = tx_queue_id, > return -EINVAL; > } >=20 > - if (dev->data->dev_started) { > - RTE_PMD_DEBUG_TRACE( > - "port %d must be stopped to allow configuration\n", port_id); > - return -EBUSY; > - } > - > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP); > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_setup, -ENOTSUP); >=20 > @@ -1596,10 +1593,19 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t= tx_queue_id, > return -EINVAL; > } >=20 > + if (dev->data->dev_started && > + !(dev_info.deferred_queue_config_capa & > + DEV_DEFERRED_TX_QUEUE_SETUP)) > + return -EINVAL; > + > txq =3D dev->data->tx_queues; > if (txq[tx_queue_id]) { > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release, > -ENOTSUP); > + if (dev->data->dev_started && > + !(dev_info.deferred_queue_config_capa & > + DEV_DEFERRED_TX_QUEUE_RELEASE)) > + return -EINVAL; > (*dev->dev_ops->tx_queue_release)(txq[tx_queue_id]); > txq[tx_queue_id] =3D NULL; > } > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.= h > index 036153306..410e58c50 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -981,6 +981,15 @@ struct rte_eth_conf { > */ > #define DEV_TX_OFFLOAD_SECURITY 0x00020000 >=20 > +#define DEV_DEFERRED_RX_QUEUE_SETUP 0x00000001 > +/**< Deferred setup rx queue */ > +#define DEV_DEFERRED_TX_QUEUE_SETUP 0x00000002 > +/**< Deferred setup tx queue */ > +#define DEV_DEFERRED_RX_QUEUE_RELEASE 0x00000004 > +/**< Deferred release rx queue */ > +#define DEV_DEFERRED_TX_QUEUE_RELEASE 0x00000008 > +/**< Deferred release tx queue */ > + I don't think we do need flags for both setup a and release. If runtime setup is supported - surely dynamic release should be supported = too. Also probably RUNTIME_RX_QUEUE_SETUP sounds a bit better. Konstantin > /* > * If new Tx offload capabilities are defined, they also must be > * mentioned in rte_tx_offload_names in rte_ethdev.c file. > @@ -1029,6 +1038,8 @@ struct rte_eth_dev_info { > /** Configured number of rx/tx queues */ > uint16_t nb_rx_queues; /**< Number of RX queues. */ > uint16_t nb_tx_queues; /**< Number of TX queues. */ > + uint64_t deferred_queue_config_capa; > + /**< queues can be setup/release after dev_start (DEV_DEFERRED_). */ > }; >=20 > /** > -- > 2.13.6