From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 0514CA495
 for <dev@dpdk.org>; Wed, 14 Mar 2018 18:41:29 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 14 Mar 2018 10:41:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,306,1517904000"; d="scan'208";a="182755921"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by orsmga004.jf.intel.com with ESMTP; 14 Mar 2018 10:41:28 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.221]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.197]) with mapi id 14.03.0319.002;
 Wed, 14 Mar 2018 17:41:04 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "thomas@monjalon.net"
 <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com>,
 "Wu, Jingjing" <jingjing.wu@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, 
 "Zhang, Qi Z" <qi.z.zhang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 3/4] app/testpmd: add command for queue
 setup
Thread-Index: AQHTsdzf+C3y/BxG70OPc8n02kHrlqPQEyTQ
Date: Wed, 14 Mar 2018 17:41:03 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772589E28FD1A@irsmsx105.ger.corp.intel.com>
References: <20180212045314.171616-1-qi.z.zhang@intel.com>
 <20180302041306.90324-1-qi.z.zhang@intel.com>
 <20180302041306.90324-4-qi.z.zhang@intel.com>
In-Reply-To: <20180302041306.90324-4-qi.z.zhang@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWM2NDNiZmYtNGRjNS00YmQzLThmZmUtYzg1ZmIzNGMxNmZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhrR3lvKzlyTFB1R0xCOHEzUnZGS3ZXdDJHV2lGWkVrQThIblh3NXFtUkE9In0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: add command for queue
 setup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Mar 2018 17:41:30 -0000

> +}
> +
> +cmdline_parse_inst_t cmd_queue_setup =3D {
> +	.f =3D cmd_queue_setup_parsed,
> +	.data =3D NULL,
> +	.help_str =3D "queue setup <rx|tx> <port_id> <queue_idx> <ring_size>",

It probably would be good to add an ability to specify rx/tx queue offloads=
 by this command.
Konstantin


> +	.tokens =3D {
> +		(void *)&cmd_queue_setup_queue,
> +		(void *)&cmd_queue_setup_setup,
> +		(void *)&cmd_queue_setup_rxtx,
> +		(void *)&cmd_queue_setup_port_id,
> +		(void *)&cmd_queue_setup_queue_idx,
> +		(void *)&cmd_queue_setup_ring_size,
> +		NULL,
> +	},
> +};
> +