From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 78EBF5B32; Sat, 24 Mar 2018 13:07:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Mar 2018 05:06:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,354,1517904000"; d="scan'208";a="44923990" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga002.jf.intel.com with ESMTP; 24 Mar 2018 05:06:57 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.216]) by IRSMSX152.ger.corp.intel.com ([169.254.6.128]) with mapi id 14.03.0319.002; Sat, 24 Mar 2018 12:06:56 +0000 From: "Ananyev, Konstantin" To: "Zhang, Qi Z" , "thomas@monjalon.net" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] ethdev: fix queue start Thread-Index: AQHTwd2XlX+qztF1DUSMB78eUTuVXqPfTTMg Date: Sat, 24 Mar 2018 12:06:55 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258A0AB3C78@irsmsx105.ger.corp.intel.com> References: <20180322125901.37141-1-qi.z.zhang@intel.com> In-Reply-To: <20180322125901.37141-1-qi.z.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjIzMzZiMDEtNmZkYS00NGE2LThiMzctYzllMzBhMTgyYzQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtXMUZiNytaU3FjeVwvbXFpVTdkMXYreWsxQXo2a1E2R3lTMlB3bXBMaHlVPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix queue start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2018 12:07:03 -0000 >=20 > Device must be started before start any queue. >=20 > Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > lib/librte_ether/rte_ethdev.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.= c > index 0590f0c10..7aa404fa5 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -732,6 +732,12 @@ rte_eth_dev_rx_queue_start(uint16_t port_id, uint16_= t rx_queue_id) > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); >=20 > dev =3D &rte_eth_devices[port_id]; > + if (!dev->data->dev_started) { > + RTE_PMD_DEBUG_TRACE( > + "port %d must be started before start any queue\n", port_id); > + return -EINVAL; > + } > + > if (rx_queue_id >=3D dev->data->nb_rx_queues) { > RTE_PMD_DEBUG_TRACE("Invalid RX queue_id=3D%d\n", rx_queue_id); > return -EINVAL; > @@ -785,6 +791,12 @@ rte_eth_dev_tx_queue_start(uint16_t port_id, uint16_= t tx_queue_id) > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); >=20 > dev =3D &rte_eth_devices[port_id]; > + if (!dev->data->dev_started) { > + RTE_PMD_DEBUG_TRACE( > + "port %d must be started before start any queue\n", port_id); > + return -EINVAL; > + } > + > if (tx_queue_id >=3D dev->data->nb_tx_queues) { > RTE_PMD_DEBUG_TRACE("Invalid TX queue_id=3D%d\n", tx_queue_id); > return -EINVAL; > -- Acked-by: Konstantin Ananyev > 2.13.6