From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 920B825A1 for ; Thu, 29 Mar 2018 11:29:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 02:29:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="212293445" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga005.jf.intel.com with ESMTP; 29 Mar 2018 02:29:03 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.216]) by IRSMSX154.ger.corp.intel.com ([169.254.12.249]) with mapi id 14.03.0319.002; Thu, 29 Mar 2018 10:29:02 +0100 From: "Ananyev, Konstantin" To: "Zhang, Qi Z" , "Dai, Wei" , "Wang, Xiao W" CC: "'dev@dpdk.org'" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API Thread-Index: AQHTxnytaXMQOEIDLkWau+9ilN6UWaPmqxIAgABHfuA= Date: Thu, 29 Mar 2018 09:29:01 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258A0AB5BB9@irsmsx105.ger.corp.intel.com> References: <20180302141105.4954-1-wei.dai@intel.com> <20180328080037.16207-1-wei.dai@intel.com> <20180328080037.16207-2-wei.dai@intel.com> <039ED4275CED7440929022BC67E706115317576C@SHSMSX103.ccr.corp.intel.com> <039ED4275CED7440929022BC67E7061153175E35@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153175E35@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWQ0ZTU0OWItY2YwMC00NjI0LWJmNTItMDU1MTQxM2E5ZDczIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFKakJweU5rXC93VldQeWhNcnh2VHJUWUFUY2V6T1lWRnpwTGVrdmJKRkw4PSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 09:29:07 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Thursday, March 29, 2018 7:09 AM > To: Dai, Wei ; Wang, Xiao W > Cc: 'dev@dpdk.org' > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offlo= ads API >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, March 28, 2018 6:08 PM > > To: Dai, Wei ; Wang, Xiao W > > Cc: dev@dpdk.org > > Subject: RE: [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API > > > > Hi Daiwei: > > > > > +static uint64_t fm10k_get_rx_queue_offloads_capa(struct rte_eth_dev > > > +*dev) { > > > + RTE_SET_USED(dev); > > > + > > > + return (uint64_t)(DEV_RX_OFFLOAD_SCATTER); > > > +} > > > > why per queue rx scattered feature here? > > My understanding is either we use scattered rx function that enable thi= s > > feature for all queues or we use non-scattered rx function that disable= this > > feature for all queues, right? >=20 > Checked with Dai Wei offline, fm10k have per queue register that can be c= onfigured to support rx scattered, > So it is per queue offload. Ok, but these days we have one RX function per device. Looking at fm10k - it clearly has different RX function for scattered and n= on-scattered case. Yes, HW does support scatter/non-scatter selection per queue, but our SW - = doesn't (same for ixgbe and i40e) So how it could be per queue offload? Konstantin > > > > Regards > > Qi