From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 098DDDED for ; Tue, 1 May 2018 11:47:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2018 02:47:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,350,1520924400"; d="scan'208";a="195775969" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga004.jf.intel.com with ESMTP; 01 May 2018 02:47:51 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.214]) by IRSMSX102.ger.corp.intel.com ([169.254.2.83]) with mapi id 14.03.0319.002; Tue, 1 May 2018 10:47:50 +0100 From: "Ananyev, Konstantin" To: "Doherty, Declan" , "dev@dpdk.org" CC: "Doherty, Declan" Thread-Topic: [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_ethdev Thread-Index: AQHT4Jm9y7SAGNQMFkqRd1gvb4k2U6QaoW4A Date: Tue, 1 May 2018 09:47:48 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258AEDC0C74@irsmsx105.ger.corp.intel.com> References: <20180430153258.1101-1-declan.doherty@intel.com> <20180430153258.1101-3-declan.doherty@intel.com> In-Reply-To: <20180430153258.1101-3-declan.doherty@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTRlZWY1OWQtY2QzNS00ZDYzLTgyNDEtZjEwMzYzYWZhZWQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjE1SmJWRFwvQzFmMXZWQUtDeDliYlFjRmp3aXRsOGRia0dBMFA3T2JEVHNFPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 09:47:53 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty > Sent: Monday, April 30, 2018 4:33 PM > To: dev@dpdk.org > Cc: Doherty, Declan > Subject: [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_= ethdev >=20 > Add NULL parameter check for rte_eth_dev_allocated() API call to > eth_ixgbe_pci_probe(). >=20 > Coverity Issue: 277216 > Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") >=20 > Signed-off-by: Declan Doherty > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_e= thdev.c > index 283dd7e49..75f927c06 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -1747,6 +1747,9 @@ eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv = __rte_unused, > struct rte_eth_dev *pf_ethdev =3D rte_eth_dev_allocated( > pci_dev->device.name); >=20 > + if (pf_ethdev =3D=3D NULL) > + return -ENODEV; > + > for (i =3D 0; i < eth_da.nb_representor_ports; i++) { > struct ixgbe_vf_info *vfinfo; > struct ixgbe_vf_representor representor; > -- Looks good - can I just ask to move pf_ethdev definition to the top of the = function? To comply with dpdk coding style. Konstantin > 2.14.3