From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D3D2ADED for ; Wed, 2 May 2018 13:28:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2018 04:28:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,354,1520924400"; d="scan'208";a="225118013" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga005.fm.intel.com with ESMTP; 02 May 2018 04:28:50 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.214]) by IRSMSX106.ger.corp.intel.com ([169.254.8.125]) with mapi id 14.03.0319.002; Wed, 2 May 2018 12:28:50 +0100 From: "Ananyev, Konstantin" To: "Zhang, Qi Z" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "Xing, Beilei" Thread-Topic: [PATCH v2 1/2] net/i40e: fix queue offload initialize Thread-Index: AQHT4cmK5S7iguxKjEmfrWlVfn/FoqQcTU8g Date: Wed, 2 May 2018 11:28:49 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258AEDC160F@irsmsx105.ger.corp.intel.com> References: <20180502035633.130415-1-qi.z.zhang@intel.com> In-Reply-To: <20180502035633.130415-1-qi.z.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2YxM2Q2ODMtMmM3Yi00Y2EyLWI5MDAtZWE2OGY4MmNjMWYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJLT1c1Tmp0S3dxSG52aHR3ejBUMHZPMVZ1eHlQRWF0bDA1aTF3SVFRUU09In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix queue offload initialize X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2018 11:28:53 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, May 2, 2018 4:57 AM > To: Yigit, Ferruh ; Ananyev, Konstantin > Cc: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > Subject: [PATCH v2 1/2] net/i40e: fix queue offload initialize >=20 > Add missing queue offload initialization. >=20 > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") > Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") >=20 > Signed-off-by: Qi Zhang > --- >=20 > v2: > - add missing part in i40e_vf_represent. >=20 > drivers/net/i40e/i40e_ethdev.c | 1 + > drivers/net/i40e/i40e_ethdev_vf.c | 1 + > drivers/net/i40e/i40e_rxtx.c | 2 ++ > drivers/net/i40e/i40e_vf_representor.c | 2 ++ > 4 files changed, 6 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 284e9cb64..a001d5b99 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -3345,6 +3345,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct r= te_eth_dev_info *dev_info) > .tx_rs_thresh =3D I40E_DEFAULT_TX_RSBIT_THRESH, > .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > ETH_TXQ_FLAGS_NOOFFLOADS, > + .offloads =3D 0, > }; >=20 > dev_info->rx_desc_lim =3D (struct rte_eth_desc_lim) { > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_et= hdev_vf.c > index 48e7ac21e..de5f460e9 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2238,6 +2238,7 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct= rte_eth_dev_info *dev_info) > .tx_rs_thresh =3D I40E_DEFAULT_TX_RSBIT_THRESH, > .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > ETH_TXQ_FLAGS_NOOFFLOADS, > + .offloads =3D 0, > }; >=20 > dev_info->rx_desc_lim =3D (struct rte_eth_desc_lim) { > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 006f5b846..755109ee5 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -1857,6 +1857,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev, > rxq->drop_en =3D rx_conf->rx_drop_en; > rxq->vsi =3D vsi; > rxq->rx_deferred_start =3D rx_conf->rx_deferred_start; > + rxq->offloads =3D rx_conf->offloads; >=20 > /* Allocate the maximun number of RX ring hardware descriptor. */ > len =3D I40E_MAX_RING_DESC; > @@ -2297,6 +2298,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev, > txq->reg_idx =3D reg_idx; > txq->port_id =3D dev->data->port_id; > txq->txq_flags =3D tx_conf->txq_flags; > + txq->offloads =3D tx_conf->offloads; > txq->vsi =3D vsi; > txq->tx_deferred_start =3D tx_conf->tx_deferred_start; >=20 Looks ok, but I think you forgot to: qinfo->conf.offloads =3D txq->offloads; inside i40e_txq_info_get() Konstantin > diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i4= 0e_vf_representor.c > index a8aa0115d..95c6696b8 100644 > --- a/drivers/net/i40e/i40e_vf_representor.c > +++ b/drivers/net/i40e/i40e_vf_representor.c > @@ -69,6 +69,7 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *e= thdev, > }, > .rx_free_thresh =3D I40E_DEFAULT_RX_FREE_THRESH, > .rx_drop_en =3D 0, > + .offloads =3D 0, > }; >=20 > dev_info->default_txconf =3D (struct rte_eth_txconf) { > @@ -81,6 +82,7 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *e= thdev, > .tx_rs_thresh =3D I40E_DEFAULT_TX_RSBIT_THRESH, > .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > ETH_TXQ_FLAGS_NOOFFLOADS, > + .offloads =3D 0, > }; >=20 > dev_info->rx_desc_lim =3D (struct rte_eth_desc_lim) { > -- > 2.13.6