From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 867601BB9B for ; Thu, 10 May 2018 19:03:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2018 10:03:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,386,1520924400"; d="scan'208";a="223220741" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga005.jf.intel.com with ESMTP; 10 May 2018 10:03:25 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.214]) by IRSMSX108.ger.corp.intel.com ([169.254.11.150]) with mapi id 14.03.0319.002; Thu, 10 May 2018 18:03:24 +0100 From: "Ananyev, Konstantin" To: "Burakov, Anatoly" , "dev@dpdk.org" CC: "Liu, Yong" , "Burakov, Anatoly" Thread-Topic: [dpdk-dev] [PATCH 3/3] memalloc: fix unmapping and marking segments as free Thread-Index: AQHT4scxG07oo5BtuUOX8ZXqCDj0qqQpO+YQ Date: Thu, 10 May 2018 17:03:24 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258AEDC56D7@irsmsx105.ger.corp.intel.com> References: <556d606e3af8ab32e920611d166a0154e472fe25.1525342009.git.anatoly.burakov@intel.com> <88ac531b5b13288971edcee16785c8cc612bdfe0.1525342009.git.anatoly.burakov@intel.com> In-Reply-To: <88ac531b5b13288971edcee16785c8cc612bdfe0.1525342009.git.anatoly.burakov@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODQwOTIzODQtZTUxOS00NTE0LWJiYTUtMzZhYmJjOTZiNWFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InlMREVMUExBRmx2eDJOc2M0YStuaXptbE4rQTJFUWVMbW03TnhKR2NVXC9nPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] memalloc: fix unmapping and marking segments as free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 17:03:30 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anatoly Burakov > Sent: Thursday, May 3, 2018 11:11 AM > To: dev@dpdk.org > Cc: Liu, Yong ; Burakov, Anatoly > Subject: [dpdk-dev] [PATCH 3/3] memalloc: fix unmapping and marking segme= nts as free >=20 > Currently, page deallocation might fail if allocator cannot get page > fd, which will leave VA space still mapped, and will also not mark > page as free. >=20 > Fix page deallocation function to always unmap space before trying > to get rid of the page itself, and always mark page as free even if > page deallocation failed. >=20 > Fixes: a5ff05d60fc5 ("mem: support unmapping pages at runtime") > Fixes: 1a7dc2252f28 ("mem: revert to using flock and add per-segment lock= files") > Cc: anatoly.burakov@intel.com >=20 > Signed-off-by: Anatoly Burakov > --- Acked-by: Konstantin Ananyev