From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 224071B56F for ; Fri, 29 Jun 2018 14:21:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2018 05:21:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,285,1526367600"; d="scan'208";a="62587116" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga002.fm.intel.com with ESMTP; 29 Jun 2018 05:21:40 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.126]) by IRSMSX151.ger.corp.intel.com ([169.254.4.216]) with mapi id 14.03.0319.002; Fri, 29 Jun 2018 13:21:39 +0100 From: "Ananyev, Konstantin" To: "Guo, Jia" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "gaetan.rivet@6wind.com" , "Wu, Jingjing" , "thomas@monjalon.net" , "motih@mellanox.com" , "matan@mellanox.com" , "Van Haaren, Harry" , "Zhang, Qi Z" , "He, Shaopeng" , "Iremonger, Bernard" CC: "jblunck@infradead.org" , "shreyansh.jain@nxp.com" , "dev@dpdk.org" , "Zhang, Helin" Thread-Topic: [PATCH V4 5/9] bus: add helper to handle sigbus Thread-Index: AQHUD5SkzkmIjiEBsEqWe7YtejsRYqR3Dq7Q///4h4CAABzxkA== Date: Fri, 29 Jun 2018 12:21:39 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258C0C43C71@irsmsx105.ger.corp.intel.com> References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <1530268248-7328-1-git-send-email-jia.guo@intel.com> <1530268248-7328-6-git-send-email-jia.guo@intel.com> <2601191342CEEE43887BDE71AB977258C0C43A49@irsmsx105.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTRkYjQ5MmMtNjhlYi00MDMyLTllN2UtMDA2OTc5MTAxZWMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC95UkNyelNwZ0w3dEFJZWZrWjhIdk40VFN0bVUzWXdlQVBLV0NDQWdaWDNYYmdEYmhtKzZTWjljM2d2NHpcLzRCIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH V4 5/9] bus: add helper to handle sigbus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 12:21:43 -0000 > -----Original Message----- > From: Guo, Jia > Sent: Friday, June 29, 2018 12:23 PM > To: Ananyev, Konstantin ; stephen@networkpl= umber.org; Richardson, Bruce > ; Yigit, Ferruh ; gae= tan.rivet@6wind.com; Wu, Jingjing > ; thomas@monjalon.net; motih@mellanox.com; matan@m= ellanox.com; Van Haaren, Harry > ; Zhang, Qi Z ; He, Sha= openg ; Iremonger, Bernard > > Cc: jblunck@infradead.org; shreyansh.jain@nxp.com; dev@dpdk.org; Zhang, H= elin > Subject: Re: [PATCH V4 5/9] bus: add helper to handle sigbus >=20 > hi, konstantin >=20 >=20 > On 6/29/2018 6:51 PM, Ananyev, Konstantin wrote: > >> +int > >> +rte_bus_sigbus_handler(const void *failure_addr) > >> +{ > >> + struct rte_bus *bus; > >> + int old_errno =3D rte_errno; > >> + int ret =3D 0; > >> + > >> + rte_errno =3D 0; > >> + > >> + bus =3D rte_bus_find(NULL, bus_handle_sigbus, failure_addr); > >> + if (bus =3D=3D NULL) { > >> + RTE_LOG(ERR, EAL, "No bus can handle the sigbus error!"); > >> + ret =3D -1; > >> + } else if (rte_errno !=3D 0) { > >> + RTE_LOG(ERR, EAL, "Failed to handle the sigbus error!"); > >> + ret =3D -1; > >> + } > >> + > >> + /* if sigbus not be handled, return back old errno. */ > >> + if (ret) > >> + rte_errno =3D old_errno; > > Hmm, not sure why we need to set/restore rte_errno here? >=20 > restore old_errno just use to let caller know that the generic sigbus > still not handler by bus hotplug handler, that involve find a bus > handle but failed and can not find a hander, and can corresponding use > the previous sigbus handler to process it. > that is also unwser your question in other patch. do you think that make > sense? Sorry, still don't understand the intention. Suppose rte_bus_find() will return NULL, in that case you'll setup rte_errn= o to what it was before calling that function. If the returned bus is not NULL, but bus_find() set's an rte_errno, you still would restore rte_ernno? What is the prupose? Why do you need to touch rte_errno at all in that function? Konstantin >=20 > >> + > >> + return ret; > >> +}