From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AEF8C25D9 for ; Wed, 25 Jul 2018 11:04:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 02:04:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,400,1526367600"; d="scan'208";a="248749639" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga006.fm.intel.com with ESMTP; 25 Jul 2018 02:04:30 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.195]) by IRSMSX108.ger.corp.intel.com ([169.254.11.169]) with mapi id 14.03.0319.002; Wed, 25 Jul 2018 10:04:29 +0100 From: "Ananyev, Konstantin" To: "Dumitrescu, Cristian" , "Mordechay Haimovsky" , Thomas Monjalon , "Singh, Jasvinder" CC: "dev@dpdk.org" , "Iremonger, Bernard" , "Pattan, Reshma" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d Thread-Index: AQHUInJOpj9peW6IqE+E2Z0dzzEFa6SeLF2AgAATHYCAACKJAIAAJ7IAgAEd51A= Date: Wed, 25 Jul 2018 09:04:28 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258DF51D3C1@irsmsx105.ger.corp.intel.com> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1876510.4y0gDTZx5Q@xps> <1925999.Zqez9Xlb98@xps> <3EB4FA525960D640B5BDFFD6A3D891268E7792AF@IRSMSX107.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E7792AF@IRSMSX107.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjcyZWYyMmItNzg3Yi00YmEyLTg3MmMtOTg5YzI0NjMzMzk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidFlPZ0xMTFZ6SkFsbE5YNVhJemhZK2FMUzUyb2dhVGFLajROTURRakdnM0VBdGhqa0JHSUZTd1wvUnZwcGtuOUkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 09:04:35 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dumitrescu, Cristian > Sent: Tuesday, July 24, 2018 5:59 PM > To: Mordechay Haimovsky ; Thomas Monjalon ; Singh, Jasvinder > > Cc: dev@dpdk.org; Iremonger, Bernard ; Patta= n, Reshma ; > olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+= d >=20 >=20 >=20 > > -----Original Message----- > > From: Mordechay Haimovsky [mailto:motih@mellanox.com] > > Sent: Tuesday, July 24, 2018 3:37 PM > > To: Thomas Monjalon ; Singh, Jasvinder > > > > Cc: dev@dpdk.org; Iremonger, Bernard ; > > Pattan, Reshma ; olivier.matz@6wind.com; > > Dumitrescu, Cristian > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctr= l+d > > > > Even after this fix we still have setups that use netvsc for example, = on > > which testpmd exits with rte_panic right after loading it even without > > touching the KBD. > > > > I recommend returning the previous prompt routine in test-pmd/cmdline.c > > and rework the SOFTNIC section there, preferably moving its poll sectio= n to > > use rte_service in a separate file cleaning the CLI files from PMD-spec= ific > > implementation. > > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > Sent: Tuesday, July 24, 2018 3:34 PM > > > To: Jasvinder Singh > > > Cc: dev@dpdk.org; bernard.iremonger@intel.com; > > > reshma.pattan@intel.com; Mordechay Haimovsky > > ; > > > olivier.matz@6wind.com; cristian.dumitrescu@intel.com > > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using c= trl+d > > > > > > Important note: > > > testpmd is currently really broken. > > > We cannot have a RC2 until it is fixed. > > > > > > > > > 24/07/2018 13:25, Thomas Monjalon: > > > > 23/07/2018 12:44, Jasvinder Singh: > > > > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission > > > > > character (EOT) on the empty command line. > > > > > > > > Please describe what is the issue and what is the cause. > > > > > > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > > > > > > > Reported-by: Mordechay Haimovsky > > > > > Signed-off-by: Jasvinder Singh > > > > > --- > > > > > app/test-pmd/cmdline.c | 10 ++++++---- > > > > > lib/librte_cmdline/cmdline.c | 2 +- > > > > > > > > It is very suspicious to change the cmdline library. > > > > If there is a bug in this library, it deserves a separate fix. > > > > > > >=20 >=20 > First, testpmd is not really broken, as only thing that changed is the Ct= rl + D behavior. I agree this is an issue that we need to fix, as > it looks that it is breaking some automation scripts for some people. >=20 > The change in behavior for Ctrl + D exit is caused by replacing the call = to cmdline_interact() with calling cmdline_poll() in a loop. > These two approaches should be identical in behavior, but it looks like t= hey are not due to some issue in the cmdline library. > Jasvinder proposed a quick patch, but it looks like something else needs = to be fixed in cmdline library in order to bring > cmdline_poll() on parity with cmdline_interact(). Any advice from Olivier= would be very much appreciated! >=20 > It is really a bad practice to use cmdline_interact() in testpmd, as it i= s a blocking call that prohibits doing other things on the same > thread that runs the CLI. Sometimes we need to run other things on the sa= me core, e.g. the slow softnic_manage() function. Curious why not use a service core for softnic background stuff, and leave = CLI one for CLI?=20 Konstantin >=20 > Worst case scenario: We can revert the cmdline_poll() back to cmdline_int= eract(), this is a small change, but not the proper way of > doing things, as this is simply hiding the issue in cmdline library. It w= ould also prevent us from testing some Soft NIC functionality.