From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 17A331C01 for ; Thu, 26 Jul 2018 11:16:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2018 02:16:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,404,1526367600"; d="scan'208";a="70057215" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 26 Jul 2018 02:16:38 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.195]) by IRSMSX152.ger.corp.intel.com ([169.254.6.61]) with mapi id 14.03.0319.002; Thu, 26 Jul 2018 10:16:38 +0100 From: "Ananyev, Konstantin" To: "Wu, Yanglong" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Bie, Tiwei" , "Yao, Lei A" , "Wu, Yanglong" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking Thread-Index: AQHUJK26uEa95O1KgEC0HsTy3VhE66ShOMww Date: Thu, 26 Jul 2018 09:16:37 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258DF51E2AE@irsmsx105.ger.corp.intel.com> References: <20180726064602.157850-1-yanglong.wu@intel.com> In-Reply-To: <20180726064602.157850-1-yanglong.wu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzlmMWNkMDItOGY4Mi00NDVjLWJiOTgtMTZmYzExMzQyMWRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib2ZLUzFDTDQxblg5aWdrSDNieGt1d01IVUdEdDlDQ2wrcnlRUFE5dTh1UThnbXd3TlVUaVgreXYwZ0Vqa3pDeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 09:16:41 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > Sent: Thursday, July 26, 2018 7:46 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Bie, Tiwei ;= Yao, Lei A ; Wu, Yanglong > > Subject: [dpdk-dev] [PATCH] net/i40e: fix max frame size checking >=20 > No need to check max frame size in TX, the checking > should be done in up layer protocal. This checking will > lead to fail for TSO or other application cases. Not sure why is that? i40e doesn't support single packet bigger then 9.5KB (or so), as I remember= . For TSO the limit is 256KB - yes, it is bibber, but still there is a limit. Might be we need to change that check, but I think we still need to keep it= . Konstantin >=20 > Fixes: bfeed0262b0c ("net/i40e: check illegal packets") >=20 > Signed-off-by: Yanglong Wu > --- > drivers/net/i40e/i40e_rxtx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 3be87fe6a..baad433a7 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -1459,8 +1459,7 @@ i40e_prep_pkts(__rte_unused void *tx_queue, struct = rte_mbuf **tx_pkts, > } >=20 > /* check the size of packet */ > - if (m->pkt_len > I40E_FRAME_SIZE_MAX || > - m->pkt_len < I40E_TX_MIN_PKT_LEN) { > + if (m->pkt_len < I40E_TX_MIN_PKT_LEN) { > rte_errno =3D -EINVAL; > return i; > } > -- > 2.11.0