From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 921CF25D9 for ; Thu, 26 Jul 2018 11:40:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2018 02:40:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,404,1526367600"; d="scan'208";a="219260563" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga004.jf.intel.com with ESMTP; 26 Jul 2018 02:40:49 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 26 Jul 2018 10:40:48 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.195]) by irsmsx155.ger.corp.intel.com ([169.254.14.181]) with mapi id 14.03.0319.002; Thu, 26 Jul 2018 10:40:47 +0100 From: "Ananyev, Konstantin" To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: 'Cody Doucette' , Olivier Matz , "Dumitrescu, Cristian" , "dev@dpdk.org" , "michel@digirati.com.br" , Qiaobin Fu Thread-Topic: [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() Thread-Index: AQHUH3mrW1MizGHZREuDbzQ4qqx2GKSeR3xwgAFnrjCAADYmAIABZK8Q Date: Thu, 26 Jul 2018 09:40:46 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258DF51E313@irsmsx105.ger.corp.intel.com> References: <2601191342CEEE43887BDE71AB977258DF51D4C3@irsmsx105.ger.corp.intel.com> <20180725132220.ztb2hazcbtdqydem@bidouze.vm.6wind.com> In-Reply-To: <20180725132220.ztb2hazcbtdqydem@bidouze.vm.6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTAzOTVhNGQtZGE0MS00MmI3LWJmZTctYmNkNzgwMWQ4NmRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieUNUcHJ0RnZJSFdzaENNZU1zM2MxQmhrVnhwNm1jM3hBbVBSVmZUVWJGazcxZ2h2Vzlnb1ZDZFNYVnhwTHB4RCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 09:40:53 -0000 >=20 > Hi Konstantin, >=20 > On Wed, Jul 25, 2018 at 09:11:30AM +0000, Ananyev, Konstantin wrote: > > Hi Cody, > > > > > -----Original Message----- > > > From: Cody Doucette [mailto:doucette@bu.edu] > > > Sent: Thursday, July 19, 2018 4:58 PM > > > To: Ananyev, Konstantin ; Olivier Matz = ; Dumitrescu, Cristian > > > > > > Cc: dev@dpdk.org; michel@digirati.com.br; Cody Doucette ; Qiaobin Fu > > > Subject: [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_h= eader() > > > > > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > > > other IPv6 extension headers when finding the fragment header. > > > > > > According to RFC 8200, there is no guarantee that the IPv6 > > > Fragment extension header will come before any other extension > > > header, even though it is recommended. > > > > > > Signed-off-by: Cody Doucette > > > Signed-off-by: Qiaobin Fu > > > Reviewed-by: Michel Machado > > > --- > > > v2: > > > * Moved IPv6 extension header definitions to lib_net. > > > > > > > Looks ok to me, though now drivers/net/failsafe fails to build on freeb= sd: > > http://mails.dpdk.org/archives/test-report/2018-July/060532.html > > > > I fixed that locally by commenting out: > > CFLAGS +=3D -D_XOPEN_SOURCE=3D700 > > at drivers/net/failsafe/Makefile > > > > Not sure what is the root cause here. > > Gaetan, do you remember why we need it for failsafe driver? > > Konstantin > > >=20 > IIRC, I was using it during the parameters parsing. > I don't see this reason anymore. >=20 > Removing it I don't see any issue so if you need to, have at it! Thanks Gaetan, Cody, would you mind to submit v3 with fixes in failsafe Makefile/meson? Konstantin >=20 > -- > Ga=EBtan Rivet > 6WIND