From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 525172C2B for ; Fri, 10 May 2019 20:24:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CB8B521BBF; Fri, 10 May 2019 14:24:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 10 May 2019 14:24:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=9Tv48F/fUeknEwiaAjjMUugIPbwwvuXTO+toTb1wxN0=; b=ia13nF+pfwlx HYK0Hce0AIe4FXwhZV7E28yWZquTzzwU4vhXv44Nx2izp2vmiF9TgO36wOBCxpoI YFILpLibX7OiFEHkz+rub1HxzVrEaKmy2Ey4wzYGDR5slBRBN1EKm9pfQLNhr/c2 5UOS9LcSI7UAXKVfgVfwvyCeK9LAY7s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9Tv48F/fUeknEwiaAjjMUugIPbwwvuXTO+toTb1wx N0=; b=ZphGM6GpPxPsn7HCghYEwDebUpjDCZfOk2D7agHHo93Mo+4wVuFPL5J5m cr7KDGCyplEKeAPbiB65PawxzC6NWezV9MlR+XvrRB5+x5zvtAMN/EatOAO/05O+ M5janQ/hkUcj7gKk9K+qWTz5IcujKfAkNdI3WqNIFjRl2d8gBQEQYlDy962w65K1 OJZXkxO6qPDXRSuADJmlR2F1SWTMy4KcWevRVAGw7h3QDath/PZkivEHaO+X1bq2 6cZMb38o8oQCTJ5Mdr7TwEd9q7JFXa2lMgzUhc0d/z+VIGvS93v3U/JmJVB5p/qt oUtw6JrcNl2FwDcUsCVXMLdeW8XwQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeekgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucfkphepkedurddukeehrddujeefrddugeelnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (149.173.185.81.rev.sfr.net [81.185.173.149]) by mail.messagingengine.com (Postfix) with ESMTPA id 163A3103D2; Fri, 10 May 2019 14:23:58 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: marcinx.smoczynski@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, shahafs@mellanox.com, gaetan.rivet@6wind.com, adrien.mazarguil@6wind.com, matan@mellanox.com Date: Fri, 10 May 2019 20:23:54 +0200 Message-ID: <2604468.nBFxeWxGDx@xps> In-Reply-To: <9076832.UKkv39EgZr@xps> References: <2F25558C1648FA498380EAC12A8612624FD953@HASMSX110.ger.corp.intel.com> <9076832.UKkv39EgZr@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 May 2019 18:24:03 -0000 re-send with fixed Cc 10/05/2019 20:17, Thomas Monjalon: > 10/05/2019 19:14, Smoczynski, MarcinX: > > To summarize we have different visibility sets for Linux and BSD when using > > XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome this situation we can > > either remove problematic XOPEN macros from mk/meson rules (drivers/net/failsafe, > > drivers/net/mlx4, drivers/net/mlx5) > > What is the consequence of removing these macros in mlx and failsafe PMDs? > > > or add explicit -D__BSD_VISIBLE when > > building for BSD. I think also that defining _GNU_SOURCE for BSD builds makes no > > sense although it does not cause any problems. > > > > I have checked that removing those problematic macros solves build problems on > > FreeBSD12 and does not break on Ubuntu 18.04. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1462AA0096 for ; Fri, 10 May 2019 20:24:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32C474C77; Fri, 10 May 2019 20:24:05 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 525172C2B for ; Fri, 10 May 2019 20:24:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CB8B521BBF; Fri, 10 May 2019 14:24:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 10 May 2019 14:24:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=9Tv48F/fUeknEwiaAjjMUugIPbwwvuXTO+toTb1wxN0=; b=ia13nF+pfwlx HYK0Hce0AIe4FXwhZV7E28yWZquTzzwU4vhXv44Nx2izp2vmiF9TgO36wOBCxpoI YFILpLibX7OiFEHkz+rub1HxzVrEaKmy2Ey4wzYGDR5slBRBN1EKm9pfQLNhr/c2 5UOS9LcSI7UAXKVfgVfwvyCeK9LAY7s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9Tv48F/fUeknEwiaAjjMUugIPbwwvuXTO+toTb1wx N0=; b=ZphGM6GpPxPsn7HCghYEwDebUpjDCZfOk2D7agHHo93Mo+4wVuFPL5J5m cr7KDGCyplEKeAPbiB65PawxzC6NWezV9MlR+XvrRB5+x5zvtAMN/EatOAO/05O+ M5janQ/hkUcj7gKk9K+qWTz5IcujKfAkNdI3WqNIFjRl2d8gBQEQYlDy962w65K1 OJZXkxO6qPDXRSuADJmlR2F1SWTMy4KcWevRVAGw7h3QDath/PZkivEHaO+X1bq2 6cZMb38o8oQCTJ5Mdr7TwEd9q7JFXa2lMgzUhc0d/z+VIGvS93v3U/JmJVB5p/qt oUtw6JrcNl2FwDcUsCVXMLdeW8XwQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeekgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucfkphepkedurddukeehrddujeefrddugeelnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (149.173.185.81.rev.sfr.net [81.185.173.149]) by mail.messagingengine.com (Postfix) with ESMTPA id 163A3103D2; Fri, 10 May 2019 14:23:58 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: marcinx.smoczynski@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, shahafs@mellanox.com, gaetan.rivet@6wind.com, adrien.mazarguil@6wind.com, matan@mellanox.com Date: Fri, 10 May 2019 20:23:54 +0200 Message-ID: <2604468.nBFxeWxGDx@xps> In-Reply-To: <9076832.UKkv39EgZr@xps> References: <2F25558C1648FA498380EAC12A8612624FD953@HASMSX110.ger.corp.intel.com> <9076832.UKkv39EgZr@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190510182354.5znwlgOlWNyZjdq5ycrRh1ZJ4tj0GSgO2KfeL4QPxP0@z> re-send with fixed Cc 10/05/2019 20:17, Thomas Monjalon: > 10/05/2019 19:14, Smoczynski, MarcinX: > > To summarize we have different visibility sets for Linux and BSD when using > > XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome this situation we can > > either remove problematic XOPEN macros from mk/meson rules (drivers/net/failsafe, > > drivers/net/mlx4, drivers/net/mlx5) > > What is the consequence of removing these macros in mlx and failsafe PMDs? > > > or add explicit -D__BSD_VISIBLE when > > building for BSD. I think also that defining _GNU_SOURCE for BSD builds makes no > > sense although it does not cause any problems. > > > > I have checked that removing those problematic macros solves build problems on > > FreeBSD12 and does not break on Ubuntu 18.04.